Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internet Defense League widget: Widget deprecation #22676

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Internet Defense League widget: Widget deprecation #22676

merged 1 commit into from
Feb 4, 2022

Conversation

ivan-ottinger
Copy link
Contributor

@ivan-ottinger ivan-ottinger commented Feb 4, 2022 •
edited
Loading

The proposed change hides the Internet Defense League widget from the block inserter and Legacy widget block drop-down menu.

Before

Block inserter Legacy Widget block
Markup on 2022-02-04 at 17:31:30 Markup on 2022-02-04 at 17:32:10

After

Block inserter Legacy Widget block
Markup on 2022-02-04 at 17:32:58 Markup on 2022-02-04 at 17:33:54

Changes proposed in this Pull Request:

  • Add filter to deprecate the Internet Defense League widget

WPCOM version of this widget is out of sync with the Jetpack version and will be deprecated in a related patch: D74186-code.

Jetpack product discussion

  • this PR is part of the Legacy Widgets Migration project: pdf5j4-4C-p2
  • more info can be found in pdf5j4-7f-p2

Does this pull request change what data or activity we track or use?

No, it does not.

Testing instructions:

  1. Navigate to Customizer → Widgets
  2. Add the Legacy widget block and take a look at the dropdown menu. The Internet Defense League widget should not be available.
  3. Try to search for the widget in the block inserter in Customizer as well. It should not come up.

@ivan-ottinger ivan-ottinger self-assigned this Feb 4, 2022
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Feature] Extra Sidebar Widgets labels Feb 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2022 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: March 1, 2022.
  • Scheduled code freeze: February 22, 2022.

@ivan-ottinger ivan-ottinger requested a review from a team February 4, 2022 16:47
@jeherve jeherve added this to the jetpack/10.7 milestone Feb 4, 2022
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Team Review labels Feb 4, 2022
@jeherve jeherve enabled auto-merge (squash) February 4, 2022 17:25
@jeherve jeherve merged commit b5a7ebb into master Feb 4, 2022
@jeherve jeherve deleted the update/internet-defense-league-widget-deprecate branch February 4, 2022 17:26
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 4, 2022
@jeherve jeherve mentioned this pull request Jun 12, 2023
Closed
jeherve added a commit that referenced this pull request Aug 1, 2023
@jeherve
Widgets: refactor Internet Defense League widget to work locally
76801ea 
See p1690903216438169-slack-CBG1CP4EN

The Internet Defense League widget is pretty old at this point, and the service behind it (Internet Defense League) doesn't exist anymore. The campaigns do not exist anymore, and the website now redirects to the company who first came up with the Internet Defense League.

The widget isn't offered to new Jetpack users today, since #22676. You can only add the widget if you use the Classic Widgets plugin.
Still, site owners who had added the widget some time in the past can still view and modify it. Since the campaign website doesn't exist anymore, we must refactor the widget so it still works:

- We remove the campaign script entirely, as well as the logic to select a campaign.
- We load the images locally instead of loading them from the remote site.
- We redirect to https://www.fightforthefuture.org/ instead of the old domain.
@jeherve jeherve mentioned this pull request Aug 1, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@ivan-ottinger ivan-ottinger

Labels
[Feature] Extra Sidebar Widgets [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Milestone
jetpack/10.7
Development

Successfully merging this pull request may close these issues.
2 participants
@ivan-ottinger @jeherve