Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack: Add coupon event properties to My Plan Partner Banner component #22705

Merged
merged 10 commits into from
Feb 7, 2022

Conversation

kallehauge
Copy link
Contributor

@kallehauge kallehauge commented Feb 7, 2022

Changes proposed in this Pull Request:

Add a coupon event property to <MyPlanPartnerCoupon> so we can differentiate partners:

  • Add a new coupon event property to <MyPlanPartnerCoupon>.
  • Allow for new optional event property in <MyPlanBanner>.

Jetpack product discussion

Does this pull request change what data or activity we track or use?

This PR adds a new property to two new events:

  • jetpack_wpa_click (we trigger a WPA click event when the banner button is clicked):
    • coupon: The coupon the user is about to claim.
  • jetpack_my_plan_banner_view (will be trigger each time a My Plan banner is viewed):
    • coupon: The coupon the user is about to claim.

Testing instructions:

  • Spin up this branch locally or as a JN beta site.
  • Create a Jetpack connection.
  • Go to /wp-admin/admin.php?jetpack-partner-coupon={COUPON}.
    • ^ Replace {COUPON} with the coupon found here: 2b922-pb.
  • Go to Jetpack > My Plan
  • If you click the Redeem button, you should be redirected to checkout.
  • Hopefully, you've both seen the banner and clicked the Redeem button by now, which means you have triggered both events mentioned in the tracking section above.
  • It will take 5-10min for the data to show up in the live data (documented here: PCYsg-4KT-p2), so go grab a ☕ - you deserve it!

@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Admin Page React-powered dashboard under the Jetpack menu labels Feb 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: March 1, 2022.
  • Scheduled code freeze: February 22, 2022.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Feb 7, 2022
@kallehauge kallehauge added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Feb 7, 2022
@kallehauge kallehauge added this to the jetpack/10.7 milestone Feb 7, 2022
@kallehauge kallehauge removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Feb 7, 2022
@kallehauge kallehauge marked this pull request as ready for review February 7, 2022 15:00
@kallehauge kallehauge changed the title Add/my plans partner coupon component Jetpack: Add coupon event properties to My Plan Partner Banner component Feb 7, 2022
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well for me, thank you!

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 7, 2022
@jeherve jeherve enabled auto-merge (squash) February 7, 2022 15:15
@jeherve jeherve merged commit 01cddea into master Feb 7, 2022
@jeherve jeherve deleted the add/my-plans-partner-coupon-component branch February 7, 2022 15:15
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants