-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency react-redux to v7.2.8 #24306
Conversation
Caution: This PR has changes that must be merged to WordPress.com |
Not much point if we don't update jetpack's dep on v6.0.1 too
Supposedly the only breaking change in the API from v6 to v7 was dropping support for React < 16.8.4.
I'm somewhat sure this isn't a *good* pattern, hopefully it's at least acceptable. Tests seem happy anyway.
I'd like a second set of eyes on the d0c482d part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The redux change looks ok to me, and I tested that I could see a <JetpackBanner>
upgrade banner working as expected.
Great news! One last step: head over to your WordPress.com diff, D80406-code, and deploy it. Thank you! |
r245605-wpcom |
Hi! I'm a Redux maintainer. Out of curiosity, what's the need to use the |
Hi @markerikson! Based on b5c2352, it seems that at the time there was some sort of conflict between the new version of react-redux (updating from 6.0.1 to 7.2.8) and static-site-generator-webpack-plugin that caused webpack to hang instead of exiting. I don't recall where I got the idea to use the alternate-renderers entry point to fix that, but I see if I check out 9854a7b and try to build it still hangs. On the other hand, if I remove the alias from our current trunk it seems to no longer hang. Bisect points to #28710 as when |
@anomiex : gotcha, thanks for the update! I'm still planning on having an |
We added this in #24306 because the static-site-generator build was hanging without it. But it seems that something when we updated to React 18 made it no longer necessary, so let's remove it.
We added this in #24306 because the static-site-generator build was hanging without it. But it seems that something when we updated to React 18 made it no longer necessary, so let's remove it.
This PR contains the following updates:
7.2.6
->7.2.8
7.1.23
->7.1.24
Release Notes
reduxjs/react-redux
v7.2.8
Compare Source
This release fixes a bug in the 7.x branch that caused
<Provider>
to unsubscribe and stop updating completely when used inside of React 18's<StrictMode>
. The new "strict effects" behavior double-mounts components, and the subscription needed to be set up inside of auseLayoutEffect
instead of auseMemo
. This was previously fixed as part of v8 development, and we've backported it.Note: If you are now using React 18, we strongly recommend using the React-Redux v8 beta instead of v7.x!. v8 has been rewritten internally to work correctly with React 18's Concurrent Rendering capabilities. React-Redux v7 will run and generally work okay with existing code, but may have rendering issues if you start using Concurrent Rendering capabilities in your code.
Now that React 18 is out, we plan to finalize React-Redux v8 and release it live within the next couple weeks. Per an update yesterday in the "v8 roadmap" thread, React-Redux v8 will be updated in the next couple days to ensure support for React 16.8+ as part of the next beta release. We would really appreciate final feedback on using React-Redux v8 beta with React 18 before we publish the final version.
Full Changelog: reduxjs/react-redux@v7.2.7...v7.2.8
v7.2.7
Compare Source
This release updates React-Redux v7's peer dependencies to accept React 18 as a valid version, only to avoid installation errors caused by NPM's "install all the peer deps and error if they don't match" behavior.
Note: If you are now using React 18, we strongly recommend using the React-Redux v8 beta instead of v7.x!. v8 has been rewritten internally to work correctly with React 18's Concurrent Rendering capabilities. React-Redux v7 will run and generally work okay with existing code, but may have rendering issues if you start using Concurrent Rendering capabilities in your code.
Now that React 18 is out, we plan to finalize React-Redux v8 and release it live within the next couple weeks. We would really appreciate final feedback on using React-Redux v8 beta with React 18 before we publish the final version.
Configuration
📅 Schedule: "before 3am on the first day of the month" in timezone UTC.
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot.