Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency react-redux to v7.2.8 #24306

Merged
merged 5 commits into from
May 13, 2022
Merged

Conversation

matticbot
Copy link
Contributor

@matticbot matticbot commented May 9, 2022

This PR contains the following updates:

Package Type Update Change
react-redux dependencies patch 7.2.6 -> 7.2.8
@types/react-redux devDependencies patch 7.1.23 -> 7.1.24

Release Notes

reduxjs/react-redux

v7.2.8

Compare Source

This release fixes a bug in the 7.x branch that caused <Provider> to unsubscribe and stop updating completely when used inside of React 18's <StrictMode>. The new "strict effects" behavior double-mounts components, and the subscription needed to be set up inside of a useLayoutEffect instead of a useMemo. This was previously fixed as part of v8 development, and we've backported it.

Note: If you are now using React 18, we strongly recommend using the React-Redux v8 beta instead of v7.x!. v8 has been rewritten internally to work correctly with React 18's Concurrent Rendering capabilities. React-Redux v7 will run and generally work okay with existing code, but may have rendering issues if you start using Concurrent Rendering capabilities in your code.

Now that React 18 is out, we plan to finalize React-Redux v8 and release it live within the next couple weeks. Per an update yesterday in the "v8 roadmap" thread, React-Redux v8 will be updated in the next couple days to ensure support for React 16.8+ as part of the next beta release. We would really appreciate final feedback on using React-Redux v8 beta with React 18 before we publish the final version.

Full Changelog: reduxjs/react-redux@v7.2.7...v7.2.8

v7.2.7

Compare Source

This release updates React-Redux v7's peer dependencies to accept React 18 as a valid version, only to avoid installation errors caused by NPM's "install all the peer deps and error if they don't match" behavior.

Note: If you are now using React 18, we strongly recommend using the React-Redux v8 beta instead of v7.x!. v8 has been rewritten internally to work correctly with React 18's Concurrent Rendering capabilities. React-Redux v7 will run and generally work okay with existing code, but may have rendering issues if you start using Concurrent Rendering capabilities in your code.

Now that React 18 is out, we plan to finalize React-Redux v8 and release it live within the next couple weeks. We would really appreciate final feedback on using React-Redux v8 beta with React 18 before we publish the final version.


Configuration

📅 Schedule: "before 3am on the first day of the month" in timezone UTC.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

@matticbot matticbot requested a review from a team as a code owner May 9, 2022 19:07
@matticbot matticbot added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial Touches WP.com Files labels May 9, 2022
@matticbot
Copy link
Contributor Author

Caution: This PR has changes that must be merged to WordPress.com
Hello matticbot! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D80406-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions bot added [Package] Ad aka WordAds [Package] Search Contains core Search functionality for Jetpack and Search plugins [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels May 9, 2022
anomiex
anomiex previously approved these changes May 9, 2022
@anomiex anomiex dismissed their stale review May 9, 2022 19:18

Not much point if we don't update jetpack's dep on v6.0.1 too

@anomiex anomiex added [Status] In Progress and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels May 9, 2022
anomiex added 3 commits May 9, 2022 15:25
Supposedly the only breaking change in the API from v6 to v7 was
dropping support for React < 16.8.4.
I'm somewhat sure this isn't a *good* pattern, hopefully it's at least
acceptable. Tests seem happy anyway.
@github-actions github-actions bot added the Admin Page React-powered dashboard under the Jetpack menu label May 9, 2022
@anomiex anomiex added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels May 10, 2022
@anomiex
Copy link
Contributor

anomiex commented May 10, 2022

I'd like a second set of eyes on the d0c482d part.

@samiff samiff self-requested a review May 12, 2022 17:42
Copy link
Contributor

@samiff samiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The redux change looks ok to me, and I tested that I could see a <JetpackBanner> upgrade banner working as expected.

@samiff samiff added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels May 12, 2022
@anomiex anomiex merged commit 11e2bc2 into master May 13, 2022
@anomiex anomiex deleted the renovate/react-redux-7.x branch May 13, 2022 13:11
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label May 13, 2022
@github-actions github-actions bot added this to the jetpack/11.0 milestone May 13, 2022
@github-actions
Copy link
Contributor

Great news! One last step: head over to your WordPress.com diff, D80406-code, and deploy it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@anomiex
Copy link
Contributor

anomiex commented May 13, 2022

r245605-wpcom

@markerikson
Copy link

Hi! I'm a Redux maintainer. Out of curiosity, what's the need to use the alternate-renderers entry point in this update?

@anomiex
Copy link
Contributor

anomiex commented Jun 21, 2023

Hi @markerikson!

Based on b5c2352, it seems that at the time there was some sort of conflict between the new version of react-redux (updating from 6.0.1 to 7.2.8) and static-site-generator-webpack-plugin that caused webpack to hang instead of exiting. I don't recall where I got the idea to use the alternate-renderers entry point to fix that, but I see if I check out 9854a7b and try to build it still hangs.

On the other hand, if I remove the alias from our current trunk it seems to no longer hang. Bisect points to #28710 as when alternate-renderers was no longer needed.

@markerikson
Copy link

@anomiex : gotcha, thanks for the update! I'm still planning on having an /alternate-renderers entry point in React-Redux v9, but was searching around to see how much it's used first. Honestly there's only a handful of usages I can find, and this one stood out as being a bit unusual.

anomiex added a commit that referenced this pull request Jun 21, 2023
We added this in #24306 because the static-site-generator build was
hanging without it. But it seems that something when we updated to React
18 made it no longer necessary, so let's remove it.
anomiex added a commit that referenced this pull request Jun 22, 2023
We added this in #24306 because the static-site-generator build was
hanging without it. But it seems that something when we updated to React
18 made it no longer necessary, so let's remove it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Package] Ad aka WordAds [Package] Search Contains core Search functionality for Jetpack and Search plugins [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants