Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dialogue and conversation blocks to beta #28842

Merged

Conversation

creativecoder
Copy link
Contributor

@creativecoder creativecoder commented Feb 8, 2023

Proposed changes:

Moves the dialogue and conversation editor extensions from the experimental build, back to beta. They remain behind a flag, and at this point, they are not going to be launched to users.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

See pdWQjU-dR-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Verify that the editor extensions are available when JETPACK_BETA_BLOCKS is set, but not when JETPACK_EXPERIMENTAL_BLOCKS is set.

@creativecoder creativecoder added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Block] Conversation [Block] Dialogue labels Feb 8, 2023
@creativecoder creativecoder self-assigned this Feb 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack remove/dialogue-and-conversation-block-from-experimental

to get started. More details: p9dueE-5Nn-p2

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Feb 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: March 7, 2023.
  • Scheduled code freeze: February 28, 2023.

@creativecoder creativecoder changed the title Remove/dialogue and conversation block from experimental Move dialogue and conversation blocks to beta Feb 8, 2023
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

This means we should then be able to remove the exceptions we had added for those blocks on WordPress.com simple 🥳

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 8, 2023
@creativecoder creativecoder enabled auto-merge (squash) February 8, 2023 17:03
@creativecoder
Copy link
Contributor Author

This means we should then be able to remove the exceptions we had added for those blocks on WordPress.com simple

@jeherve Thanks for the reminder! See D100746-code

@creativecoder creativecoder merged commit f1a6c8f into trunk Feb 8, 2023
@creativecoder creativecoder deleted the remove/dialogue-and-conversation-block-from-experimental branch February 8, 2023 17:51
@github-actions github-actions bot added this to the jetpack/11.9 milestone Feb 8, 2023
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Conversation [Block] Dialogue [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants