Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: remove backwards-compatibility WP 6.0 code #30126

Merged
merged 5 commits into from
Apr 18, 2023

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Apr 17, 2023

Proposed changes:

Following #30120, let's remove code that was only in there to keep backwards-compatibility with WP 6.0.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

See #27795

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Check impacted files, those features should keep working.
    • Go to Posts > Add New, and add a new Business Hours block
    • It should work with no js errors in the console, and regardless of your site language.

@jeherve jeherve added [Status] In Progress [Pri] Normal [Focus] Compatibility Ensuring our products play well with third-parties labels Apr 17, 2023
@jeherve jeherve self-assigned this Apr 17, 2023
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests [Feature] Shortcodes / Embeds labels Apr 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: May 2, 2023.
  • Scheduled code freeze: April 24, 2023.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2023

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack update/backwards-compat-61

to get started. More details: p9dueE-5Nn-p2

@kraftbj kraftbj self-requested a review April 17, 2023 14:44
@jeherve jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Apr 17, 2023
@jeherve jeherve merged commit fd90454 into trunk Apr 18, 2023
@jeherve jeherve deleted the update/backwards-compat-61 branch April 18, 2023 06:38
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Apr 18, 2023
@zinigor zinigor added this to the Jetpack/12.1 milestone Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Business Hours [Feature] Shortcodes / Embeds [Focus] Compatibility Ensuring our products play well with third-parties [JS Package] Components [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal RNA [Tests] Includes Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants