-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boost: On premium upgrade (if image guide is enabled), request an ISA report #31888
Boost: On premium upgrade (if image guide is enabled), request an ISA report #31888
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Boost plugin:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here look like they would work.
However, I am not sure we want to kick off a report which will generate hundreds or thousands of requests. See: https://github.com/Automattic/boost-cloud/issues/310#issuecomment-1637306125
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, after a conversation (https://github.com/Automattic/boost-cloud/issues/310) about it, Iv'e been convinced that this will help demonstrate the value of the subscription after purchase.
After merging with trunk, the linter somehow messed up and made changes to files outside this PR. Reverted the change with b2be646. |
Cherry-picked 9cd5215 |
… request an ISA report (#31888) * Update purchase flow to request a new ISA report if image guide is on * add changelog * Revert linter update after merging with trunk * [not verified] Revert linter update after merging with trunk * Remove critical css regen code, as it happens in the back-end now
Fixes https://github.com/Automattic/boost-cloud/issues/310
Proposed changes:
Other information:
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
no
Testing instructions:
To easily test the above if you have premium, simply open
/wp-admin/admin.php?page=jetpack-boost#purchase-successful
. This will force the Image Size Analysis to request a report.