Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost: On premium upgrade (if image guide is enabled), request an ISA report #31888

Merged
merged 6 commits into from
Jul 19, 2023

Conversation

dilirity
Copy link
Member

Fixes https://github.com/Automattic/boost-cloud/issues/310

Proposed changes:

  • If Image Guide is enabled after upgrading to premium and landing on the Purchase Successful page, an Image Size Analysis report will be automatically requested.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • Setup this version of Boost (use the free version);
  • Make sure you have images on the website;
  • Enable Image Guide;
  • Upgrade to Premium;
  • After you get redirected back to the Purchase Successful page, click continue and scroll down to the Image Size Analysis section
  • There should be a report in progress (or maybe completed).

To easily test the above if you have premium, simply open /wp-admin/admin.php?page=jetpack-boost#purchase-successful. This will force the Image Size Analysis to request a report.

@dilirity dilirity added this to the boost/2.0.0 milestone Jul 14, 2023
@dilirity dilirity requested a review from a team July 14, 2023 12:59
@dilirity dilirity self-assigned this Jul 14, 2023
@dilirity dilirity changed the title Boost: Request an ISA report after premium upgrade if Image Guide is enabled Boost: On premium upgrade (if image guide is enabled), request an ISA report Jul 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Boost plugin:

  • Next scheduled release: August 1, 2023.
  • Scheduled code freeze: July 24, 2023.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jul 14, 2023
@dilirity dilirity added [Status] Needs Team Review and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jul 14, 2023
Copy link
Member

@thingalon thingalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here look like they would work.

However, I am not sure we want to kick off a report which will generate hundreds or thousands of requests. See: https://github.com/Automattic/boost-cloud/issues/310#issuecomment-1637306125

thingalon
thingalon previously approved these changes Jul 18, 2023
Copy link
Member

@thingalon thingalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, after a conversation (https://github.com/Automattic/boost-cloud/issues/310) about it, Iv'e been convinced that this will help demonstrate the value of the subscription after purchase.

@github-actions github-actions bot added [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Feature] Contact Form [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jul 18, 2023
@dilirity dilirity removed [Feature] Contact Form [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Package] Forms labels Jul 18, 2023
@dilirity
Copy link
Member Author

After merging with trunk, the linter somehow messed up and made changes to files outside this PR. Reverted the change with b2be646.

@thingalon thingalon merged commit 91fe05f into trunk Jul 19, 2023
@thingalon thingalon deleted the update/boost/request-isa-after-premium-upgrade branch July 19, 2023 03:21
@haqadn
Copy link
Contributor

haqadn commented Jul 19, 2023

Cherry-picked 9cd5215

haqadn pushed a commit that referenced this pull request Jul 19, 2023
… request an ISA report (#31888)

* Update purchase flow to request a new ISA report if image guide is on

* add changelog

* Revert linter update after merging with trunk

* [not verified] Revert linter update after merging with trunk

* Remove critical css regen code, as it happens in the back-end now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants