Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added WordPress 6.1 test suite to the matrix. #32366

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

zinigor
Copy link
Member

@zinigor zinigor commented Aug 9, 2023

We have been setting WordPress "previous" to 6.1 directly, this PR changes that to 6.2. In addition to that, we add a special test suite to continue testing 6.1 in the interim between Jetpack 12.4 and Jetpack 12.5.

Proposed changes:

  • Moves 'previous' to 6.2 instead of 6.1.
  • Adds a 'special' test suite that will continue testing in WordPress 6.1.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • CI should be OK

@zinigor zinigor requested a review from kraftbj August 9, 2023 14:42
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Aug 9, 2023
@samiff samiff added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Aug 9, 2023
@samiff samiff added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Aug 9, 2023
@zinigor zinigor enabled auto-merge (squash) August 9, 2023 18:01
@zinigor zinigor merged commit ce6366b into trunk Aug 9, 2023
@zinigor zinigor deleted the add/special-ci-test-case-for-6.1 branch August 9, 2023 18:03
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Aug 9, 2023
haqadn pushed a commit that referenced this pull request Aug 17, 2023
* Added WordPress 6.1 test suite to the matrix.

* Added a special 'special' case.
jeherve added a commit that referenced this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions GitHub actions used to automate some of the work around releases and repository management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants