Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IS: add conditional to use new method introduced in WP 6.3 #32454

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Aug 14, 2023

Proposed changes:

WP_Scripts::print_inline_script was deprecated in WordPress 6.3, in favor of WP_Scripts::get_inline_script_data. Let's start using that to avoid deprecation notices, when we're running WP 6.3 or above.

See https://core.trac.wordpress.org/ticket/12009

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Primary issue: #31638

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Start with a site with more than 10 posts.

  • Enable a classic theme that bundles support for Infinite Scroll, such as "Superhero".
  • Go to Jetpack > Settings and enable Infinite Scroll (e.g. set it to "Load more posts as the reader scrolls down").
  • Load the home page and scroll down
    • You should see more posts appearing as you scroll down the page.

@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Infinite Scroll [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] Normal labels Aug 14, 2023
@jeherve jeherve added this to the jetpack/12.5 milestone Aug 14, 2023
@jeherve jeherve self-assigned this Aug 14, 2023
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Aug 14, 2023
@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

  • Next scheduled release: August 23, 2023.
  • Scheduled code freeze: August 21, 2023.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2023

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta > Jetpack and enable the update/infinite-scripts branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/infinite-scripts
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@samiff samiff self-requested a review August 14, 2023 16:46
Copy link
Contributor

@samiff samiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me 👍

@samiff samiff added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Aug 14, 2023
@jeherve jeherve merged commit 23a00bb into trunk Aug 14, 2023
@jeherve jeherve deleted the update/infinite-scripts branch August 14, 2023 17:33
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Infinite Scroll [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants