-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IS: add conditional to use new method introduced in WP 6.3 #32454
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked for me 👍
Proposed changes:
WP_Scripts::print_inline_script
was deprecated in WordPress 6.3, in favor ofWP_Scripts::get_inline_script_data
. Let's start using that to avoid deprecation notices, when we're running WP 6.3 or above.See https://core.trac.wordpress.org/ticket/12009
Other information:
Jetpack product discussion
Primary issue: #31638
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Start with a site with more than 10 posts.