Social: Connections API schema front end changes #40539

manzoorwanijk · 2024-12-10T12:23:15Z

Related to #40677

Proposed changes:

Use the updated connections schema on the front-end following Move wpcom/v2/publicize/connections endpoint to publicize package #40607

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Go to connections management
Verify that the connection name is displayed correctly for all the connections
Remove the display name from your Bluesky profile and reconnect it
Verify that the display name for the connection is the blueksy handle
Add a Mastodon connection and then break the connection by removing Jetpack here.
Change the tab in the edior and come back or reload the page in case of settings page to have the broken connection reflected
In the editor, verify that the broken connection notice shows up fine.
Reconnect the broken Mastodon account
Verify that reconnection works fine (with the correct handle)
In editor, toggle the connections ON/OFF to confirm it works fine
Try to send post only to 1 network, rest toggled off to verify it works
If you have an unsupported network like Twitter added, verify it's marked as unsupported. I verified it for my old Twitter connection.
In the Jetpack sidebar, click on Preview social posts
Verify that the connections are displayed fine

github-actions · 2024-12-10T12:24:13Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/social-schema-front-end-changes branch.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/social-schema-front-end-changes

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2024-12-10T12:24:35Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

gmjuhasz

This looks good to me, but @pablinos should take a look as well as it's a fairly big change

* Create connections class for caching * Update script data to use connections from the REST endpoint * changelog * Restore deprecated connection fields for time being * Disable caching for now * Fix display_name for Mastodon * Remove the unused caching logic

gmjuhasz

This still works as expected

* Social: Use connections REST endpoint for initial state (#40677) * Create connections class for caching * Update script data to use connections from the REST endpoint * changelog * Restore deprecated connection fields for time being * Disable caching for now * Fix display_name for Mastodon * Remove the unused caching logic * Social: Connections API schema front end changes (#40539) * Social: Use connections REST endpoint for initial state (#40677) * Create connections class for caching * Update script data to use connections from the REST endpoint * changelog * Restore deprecated connection fields for time being * Disable caching for now * Fix display_name for Mastodon * Remove the unused caching logic * Update connect-form.tsx * Create connections class for caching * Update types for connection object * Update connection actions to reflect new types * Mark 'id' as deprecated * Add changelog * Deprecated fields should be optional * Fix TS error * Update unit tests * Replace/remove deprecated props usage * Remove unused code * Fix connection selectors * Fix unit tests * Reduce the number of changes * Fix type * Oops! It should be negation * Restore class-connections.php * Social | Add site context for publicize endpoints (#40704) * Allow requests as blog in base controller * Add filters for connections controller * Add changelog * Update baseline.php * Rename the 'include' param to 'scope' for clarity * Return shared connections by default * Remove scope parameter in favour of request context * Only pass test_connections to WPCOM * Update baseline.php * Social: Implement connections caching with the updated endpoint (#40892) * Update connections class to implement caching * Add get_all_for_user method * Pass cached connections to initial state * Invalidate cache on XMLRPC request * Add changelog * Remove eager loading of connections following cache invalidation * Improve clear caching logic to handle race condition * Social: Replace can_disconnect with a store data selector (#40888) * Pass the connected users WPCOM data to the UI * Augment wpcom for user object * Create canUserManageConnection selector * Replace can_disconnect with the new selector * Fix unit tests * Add changelog * Fix user data for WPCOM sites * Fix unit tests * Add changelog * Social | Restore must_reauth as connection status (#40946) * Add "must_reauth" to status in REST schema * Restore the UI changes to consider must_reauth status * Add changelog * Don't disable connections with must_reauth status must_reauth means that the connection will break soon, but it still works. We'll display an appropriate notice. --------- Co-authored-by: Paul Bunkham <[email protected]> * Social | Clean up connections controller to use connections class (#40982) * Create Proxy_Requests class for re-usability * Move is_wpcom utility to Publicize_Utils class * Move connections specific logic from REST controller to connections class * Add changelog * Update baseline.php * Move publicize permissions check to its own method * Social | Fix connect button for broken connections (#40995) * Social | Fix connected accounts not marked as such on confirmation screen (#40997) * Social | Fix connected accounts not marked as such on confirmation screen * Add a comment * Social | Update connections schema to change `user_id` to `wpcom_user_id` (#41025) * Social | Update connections schema to change user_id to wpcom_user_id * Fix wpcom_user_id for post connections field * Add changelog * Social | Implement the other CRUD operations for connections (#40928) * WIP * Pass the connection ID in the URL * Pass connection_id for delete proxy request * Allow overriding $request_options * Clean up debugging * Add changelog * Add changelog for js changes * Fix static analysis issues * Remove unused code * Update baseline.php --------- Co-authored-by: Paul Bunkham <[email protected]> * Unify changelogs --------- Co-authored-by: Paul Bunkham <[email protected]>

* Social: Use connections REST endpoint for initial state (#40677) * Create connections class for caching * Update script data to use connections from the REST endpoint * changelog * Restore deprecated connection fields for time being * Disable caching for now * Fix display_name for Mastodon * Remove the unused caching logic * Social: Connections API schema front end changes (#40539) * Social: Use connections REST endpoint for initial state (#40677) * Create connections class for caching * Update script data to use connections from the REST endpoint * changelog * Restore deprecated connection fields for time being * Disable caching for now * Fix display_name for Mastodon * Remove the unused caching logic * Update connect-form.tsx * Create connections class for caching * Update types for connection object * Update connection actions to reflect new types * Mark 'id' as deprecated * Add changelog * Deprecated fields should be optional * Fix TS error * Update unit tests * Replace/remove deprecated props usage * Remove unused code * Fix connection selectors * Fix unit tests * Reduce the number of changes * Fix type * Oops! It should be negation * Restore class-connections.php * Social | Add site context for publicize endpoints (#40704) * Allow requests as blog in base controller * Add filters for connections controller * Add changelog * Update baseline.php * Rename the 'include' param to 'scope' for clarity * Return shared connections by default * Remove scope parameter in favour of request context * Only pass test_connections to WPCOM * Update baseline.php * Social: Implement connections caching with the updated endpoint (#40892) * Update connections class to implement caching * Add get_all_for_user method * Pass cached connections to initial state * Invalidate cache on XMLRPC request * Add changelog * Remove eager loading of connections following cache invalidation * Improve clear caching logic to handle race condition * Social: Replace can_disconnect with a store data selector (#40888) * Pass the connected users WPCOM data to the UI * Augment wpcom for user object * Create canUserManageConnection selector * Replace can_disconnect with the new selector * Fix unit tests * Add changelog * Fix user data for WPCOM sites * Fix unit tests * Add changelog * Social | Restore must_reauth as connection status (#40946) * Add "must_reauth" to status in REST schema * Restore the UI changes to consider must_reauth status * Add changelog * Don't disable connections with must_reauth status must_reauth means that the connection will break soon, but it still works. We'll display an appropriate notice. --------- Co-authored-by: Paul Bunkham <[email protected]> * Social | Clean up connections controller to use connections class (#40982) * Create Proxy_Requests class for re-usability * Move is_wpcom utility to Publicize_Utils class * Move connections specific logic from REST controller to connections class * Add changelog * Update baseline.php * Move publicize permissions check to its own method * Social | Fix connect button for broken connections (#40995) * Social | Fix connected accounts not marked as such on confirmation screen (#40997) * Social | Fix connected accounts not marked as such on confirmation screen * Add a comment * Social | Update connections schema to change `user_id` to `wpcom_user_id` (#41025) * Social | Update connections schema to change user_id to wpcom_user_id * Fix wpcom_user_id for post connections field * Add changelog * Social | Implement the other CRUD operations for connections (#40928) * WIP * Pass the connection ID in the URL * Pass connection_id for delete proxy request * Allow overriding $request_options * Clean up debugging * Add changelog * Add changelog for js changes * Fix static analysis issues * Remove unused code * Update baseline.php --------- Co-authored-by: Paul Bunkham <[email protected]> * Unify changelogs * Unify js changelog * It should be 'blog' not 'site' * Social | Use the proxy trait from connection package (#41087) * Update baseline.php * Update phan * Social | Fix social connections list initial state feature check (#41151) * Social | Enable connections management for WPCOM sites --------- Co-authored-by: Paul Bunkham <[email protected]>

* Social: Use connections REST endpoint for initial state (#40677) * Create connections class for caching * Update script data to use connections from the REST endpoint * changelog * Restore deprecated connection fields for time being * Disable caching for now * Fix display_name for Mastodon * Remove the unused caching logic * Social: Connections API schema front end changes (#40539) * Social: Use connections REST endpoint for initial state (#40677) * Create connections class for caching * Update script data to use connections from the REST endpoint * changelog * Restore deprecated connection fields for time being * Disable caching for now * Fix display_name for Mastodon * Remove the unused caching logic * Update connect-form.tsx * Create connections class for caching * Update types for connection object * Update connection actions to reflect new types * Mark 'id' as deprecated * Add changelog * Deprecated fields should be optional * Fix TS error * Update unit tests * Replace/remove deprecated props usage * Remove unused code * Fix connection selectors * Fix unit tests * Reduce the number of changes * Fix type * Oops! It should be negation * Restore class-connections.php * Social | Add site context for publicize endpoints (#40704) * Allow requests as blog in base controller * Add filters for connections controller * Add changelog * Update baseline.php * Rename the 'include' param to 'scope' for clarity * Return shared connections by default * Remove scope parameter in favour of request context * Only pass test_connections to WPCOM * Update baseline.php * Social: Implement connections caching with the updated endpoint (#40892) * Update connections class to implement caching * Add get_all_for_user method * Pass cached connections to initial state * Invalidate cache on XMLRPC request * Add changelog * Remove eager loading of connections following cache invalidation * Improve clear caching logic to handle race condition * Social: Replace can_disconnect with a store data selector (#40888) * Pass the connected users WPCOM data to the UI * Augment wpcom for user object * Create canUserManageConnection selector * Replace can_disconnect with the new selector * Fix unit tests * Add changelog * Fix user data for WPCOM sites * Fix unit tests * Add changelog * Social | Restore must_reauth as connection status (#40946) * Add "must_reauth" to status in REST schema * Restore the UI changes to consider must_reauth status * Add changelog * Don't disable connections with must_reauth status must_reauth means that the connection will break soon, but it still works. We'll display an appropriate notice. --------- Co-authored-by: Paul Bunkham <[email protected]> * Social | Clean up connections controller to use connections class (#40982) * Create Proxy_Requests class for re-usability * Move is_wpcom utility to Publicize_Utils class * Move connections specific logic from REST controller to connections class * Add changelog * Update baseline.php * Move publicize permissions check to its own method * Social | Fix connect button for broken connections (#40995) * Social | Fix connected accounts not marked as such on confirmation screen (#40997) * Social | Fix connected accounts not marked as such on confirmation screen * Add a comment * Social | Update connections schema to change `user_id` to `wpcom_user_id` (#41025) * Social | Update connections schema to change user_id to wpcom_user_id * Fix wpcom_user_id for post connections field * Add changelog * Social | Implement the other CRUD operations for connections (#40928) * WIP * Pass the connection ID in the URL * Pass connection_id for delete proxy request * Allow overriding $request_options * Clean up debugging * Add changelog * Add changelog for js changes * Fix static analysis issues * Remove unused code * Update baseline.php --------- Co-authored-by: Paul Bunkham <[email protected]> * Unify changelogs --------- Co-authored-by: Paul Bunkham <[email protected]>

* Social: Use connections REST endpoint for initial state (#40677) * Create connections class for caching * Update script data to use connections from the REST endpoint * changelog * Restore deprecated connection fields for time being * Disable caching for now * Fix display_name for Mastodon * Remove the unused caching logic * Social: Connections API schema front end changes (#40539) * Social: Use connections REST endpoint for initial state (#40677) * Create connections class for caching * Update script data to use connections from the REST endpoint * changelog * Restore deprecated connection fields for time being * Disable caching for now * Fix display_name for Mastodon * Remove the unused caching logic * Update connect-form.tsx * Create connections class for caching * Update types for connection object * Update connection actions to reflect new types * Mark 'id' as deprecated * Add changelog * Deprecated fields should be optional * Fix TS error * Update unit tests * Replace/remove deprecated props usage * Remove unused code * Fix connection selectors * Fix unit tests * Reduce the number of changes * Fix type * Oops! It should be negation * Restore class-connections.php * Social | Add site context for publicize endpoints (#40704) * Allow requests as blog in base controller * Add filters for connections controller * Add changelog * Update baseline.php * Rename the 'include' param to 'scope' for clarity * Return shared connections by default * Remove scope parameter in favour of request context * Only pass test_connections to WPCOM * Update baseline.php * Social: Implement connections caching with the updated endpoint (#40892) * Update connections class to implement caching * Add get_all_for_user method * Pass cached connections to initial state * Invalidate cache on XMLRPC request * Add changelog * Remove eager loading of connections following cache invalidation * Improve clear caching logic to handle race condition * Social: Replace can_disconnect with a store data selector (#40888) * Pass the connected users WPCOM data to the UI * Augment wpcom for user object * Create canUserManageConnection selector * Replace can_disconnect with the new selector * Fix unit tests * Add changelog * Fix user data for WPCOM sites * Fix unit tests * Add changelog * Social | Restore must_reauth as connection status (#40946) * Add "must_reauth" to status in REST schema * Restore the UI changes to consider must_reauth status * Add changelog * Don't disable connections with must_reauth status must_reauth means that the connection will break soon, but it still works. We'll display an appropriate notice. --------- Co-authored-by: Paul Bunkham <[email protected]> * Social | Clean up connections controller to use connections class (#40982) * Create Proxy_Requests class for re-usability * Move is_wpcom utility to Publicize_Utils class * Move connections specific logic from REST controller to connections class * Add changelog * Update baseline.php * Move publicize permissions check to its own method * Social | Fix connect button for broken connections (#40995) * Social | Fix connected accounts not marked as such on confirmation screen (#40997) * Social | Fix connected accounts not marked as such on confirmation screen * Add a comment * Social | Update connections schema to change `user_id` to `wpcom_user_id` (#41025) * Social | Update connections schema to change user_id to wpcom_user_id * Fix wpcom_user_id for post connections field * Add changelog * Social | Implement the other CRUD operations for connections (#40928) * WIP * Pass the connection ID in the URL * Pass connection_id for delete proxy request * Allow overriding $request_options * Clean up debugging * Add changelog * Add changelog for js changes * Fix static analysis issues * Remove unused code * Update baseline.php --------- Co-authored-by: Paul Bunkham <[email protected]> * Unify changelogs * Unify js changelog * It should be 'blog' not 'site' * Social | Use the proxy trait from connection package (#41087) * Update baseline.php * Update phan * Social | Fix social connections list initial state feature check (#41151) * Social | Enable connections management for WPCOM sites --------- Co-authored-by: Paul Bunkham <[email protected]>

github-actions bot added [Feature] Publicize Now Jetpack Social, auto-sharing [JS Package] Publicize Components [Status] In Progress RNA labels Dec 10, 2024

manzoorwanijk added the DO NOT MERGE don't merge it! label Dec 10, 2024

manzoorwanijk force-pushed the update/social-schema-front-end-changes branch from d4e04c0 to f04b25c Compare December 13, 2024 08:44

manzoorwanijk added the [Type] Task label Dec 13, 2024

manzoorwanijk self-assigned this Dec 13, 2024

github-actions bot added the [Tests] Includes Tests label Dec 13, 2024

manzoorwanijk force-pushed the update/social-schema-front-end-changes branch from 0b628da to 8eb70f8 Compare December 19, 2024 05:46

manzoorwanijk marked this pull request as ready for review December 19, 2024 06:20

manzoorwanijk added [Status] Needs Team Review and removed [Status] In Progress DO NOT MERGE don't merge it! labels Dec 19, 2024

manzoorwanijk requested a review from a team December 19, 2024 06:20

github-actions bot added the [Status] In Progress label Dec 19, 2024

manzoorwanijk force-pushed the update/social-schema-front-end-changes branch from ebf0c82 to 4a4a0e2 Compare December 19, 2024 07:33

manzoorwanijk changed the base branch from trunk to update/unify-social-connections-schema December 19, 2024 07:33

manzoorwanijk added DO NOT MERGE don't merge it! and removed [Status] In Progress labels Dec 19, 2024

manzoorwanijk force-pushed the update/unify-social-connections-schema branch from 1adc9a8 to d1762a9 Compare December 19, 2024 08:29

manzoorwanijk force-pushed the update/social-schema-front-end-changes branch from 4a4a0e2 to 0379da4 Compare December 19, 2024 08:30

gmjuhasz reviewed Dec 19, 2024

View reviewed changes

manzoorwanijk removed the DO NOT MERGE don't merge it! label Dec 20, 2024

Base automatically changed from update/unify-social-connections-schema to social/unified-connections-management December 20, 2024 09:42

github-actions bot added the [Package] Publicize label Dec 20, 2024

manzoorwanijk force-pushed the social/unified-connections-management branch from d6b615d to a749a20 Compare December 20, 2024 09:44

manzoorwanijk added 16 commits December 26, 2024 10:47

Update connect-form.tsx

4be160c

Create connections class for caching

e5538d1

Update types for connection object

b29d224

Update connection actions to reflect new types

64f4fe3

Mark 'id' as deprecated

ea0328d

Add changelog

4a5707d

Deprecated fields should be optional

dcab22d

Fix TS error

bb8e010

Update unit tests

0917bbc

Replace/remove deprecated props usage

5e8e104

Remove unused code

93de467

Fix connection selectors

9bb9350

Fix unit tests

375cb28

Reduce the number of changes

0bd007d

Fix type

0124fcb

Oops! It should be negation

895e7bd

manzoorwanijk force-pushed the update/social-schema-front-end-changes branch from 0379da4 to 895e7bd Compare December 26, 2024 05:18

github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Dec 26, 2024

Restore class-connections.php

f03658b

manzoorwanijk force-pushed the social/unified-connections-management branch from 9af33a7 to 4af0cc4 Compare January 7, 2025 05:01

gmjuhasz approved these changes Jan 7, 2025

View reviewed changes

manzoorwanijk merged commit b019a20 into social/unified-connections-management Jan 7, 2025
56 checks passed

manzoorwanijk deleted the update/social-schema-front-end-changes branch January 7, 2025 10:19

github-actions bot removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Needs Team Review labels Jan 7, 2025

manzoorwanijk mentioned this pull request Jan 10, 2025

Social | Restore must_reauth as connection status #40946

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Social: Connections API schema front end changes #40539

Social: Connections API schema front end changes #40539

manzoorwanijk commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024 •

edited

Loading

gmjuhasz left a comment

gmjuhasz left a comment

Social: Connections API schema front end changes #40539

Social: Connections API schema front end changes #40539

Conversation

manzoorwanijk commented Dec 10, 2024 • edited Loading

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Dec 10, 2024 • edited Loading

github-actions bot commented Dec 10, 2024 • edited Loading

gmjuhasz left a comment

Choose a reason for hiding this comment

gmjuhasz left a comment

Choose a reason for hiding this comment

manzoorwanijk commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024 •

edited

Loading