Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect Status: Combine multiple vulnerabilities for the same extension into single threat objects #40863

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

nateweller
Copy link
Contributor

@nateweller nateweller commented Jan 6, 2025

Updates the protect-status package to group vulnerabilities by extension (i.e. one threat per vulnerable extension).

Proposed changes:

  • Adds Vulnerability_Model class.
  • Adds Threat_Model::$vulnerabilities property.
  • Updates Protect_Status to generate a single Threat_Model per vulnerable extension, with the relevant vulnerabilities included as a property of the threat.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

peb6dq-3ma-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Validate results from jetpack-protect/v1/status with a free plan.
Screenshot 2025-01-06 at 3 11 05 PM

@nateweller nateweller added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress labels Jan 6, 2025
@nateweller nateweller requested a review from a team January 6, 2025 20:58
@nateweller nateweller self-assigned this Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the protect-status/combine-vulns-into-extension-threat branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack protect-status/combine-vulns-into-extension-threat
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@nateweller nateweller force-pushed the protect-status/combine-vulns-into-extension-threat branch from a0cd6e5 to 809cacc Compare January 15, 2025 16:59
…erable extension threat

changelog

minor adjustments

changelog

add source to generator

minor adjustments

Add typed params

minor adjustments

use generator for core vulns threat
@nateweller nateweller force-pushed the protect-status/combine-vulns-into-extension-threat branch from 8128367 to 51ecb63 Compare January 15, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Protect Models [Package] Protect Status [Status] In Progress [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant