-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Settings > Security menu item for wpcom atomic sites #41112
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
projects/packages/masterbar/src/admin-menu/class-base-admin-menu.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this with Atomic Default site, and it worked well both in wp-admin and Calypso!
p1737072183699669/1736918927.990999-slack-CRWCHQGUB
* Remove Settings > Security menu item from atomic sites menu * changelog * Remove duplicate function
Related to Automattic/wp-calypso#98249
Proposed changes:
Other information:
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Using a woa dev blog with the Jetpack beta tester plugin installed. Select by branch:
update/remove-security-settings
for "WordPress.com Features".Setup a
define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true );
in~/htdocs/wp-config.php
of your woa blog.To test sandbox for regressions, install the latest jetpack/mu plugin builds:
To build manually
Select Bleeding Edge for "WordPress.com Features" in the beta test plugin.
Build and sync the mu plugin to your woa dev blog:
Setup a
define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true );
in~/htdocs/wp-config.php
Note classic view already hides this, but wp-admin with default view and the drop down view set classic does not.
You can also check the api response for
wpcom/v2/sites/woatest1254131.wpcomstaging.com/admin-menu
in the developer console.