Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Settings > Security menu item for wpcom atomic sites #41112

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

lsl
Copy link
Contributor

@lsl lsl commented Jan 16, 2025

Related to Automattic/wp-calypso#98249

Proposed changes:

  • Disables addition of the Settings > Security menu item for atomic sites in the hold out experiment.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Using a woa dev blog with the Jetpack beta tester plugin installed. Select by branch: update/remove-security-settings for "WordPress.com Features".

Setup a define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); in ~/htdocs/wp-config.php of your woa blog.

  • Confirm the Settings > Security menu item is still present in wp-admin and calypso.
  • Assign yourself to this treatment group: 22167-explat-experiment
  • Confirm the Settings > Security menu item is no longer present in in wp-admin and calypso.

To test sandbox for regressions, install the latest jetpack/mu plugin builds:

bin/jetpack-downloader test jetpack update/remove-security-settings
bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/remove-security-settings

To build manually

Select Bleeding Edge for "WordPress.com Features" in the beta test plugin.

Build and sync the mu plugin to your woa dev blog:

jetpack build plugins/mu-wpcom-plugin packages/jetpack-mu-wpcom
jetpack rsync mu-wpcom-plugin woa:~/htdocs/wp-content/plugins/jetpack-mu-wpcom-plugin-dev --watch

Setup a define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); in ~/htdocs/wp-config.php

Before After
calypso Screenshot(39) Screenshot(38)
wp-admin Screenshot(42) Screenshot(41)

Note classic view already hides this, but wp-admin with default view and the drop down view set classic does not.

You can also check the api response for wpcom/v2/sites/woatest1254131.wpcomstaging.com/admin-menu in the developer console.

Before After
Screenshot(37) Screenshot(36)

@lsl lsl requested a review from a team January 16, 2025 04:59
Copy link
Contributor

github-actions bot commented Jan 16, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/remove-security-settings branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/remove-security-settings
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/remove-security-settings
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added the [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations label Jan 16, 2025
Copy link
Contributor

github-actions bot commented Jan 16, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added [Package] Masterbar [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 16, 2025
@lsl lsl self-assigned this Jan 16, 2025
@lsl lsl changed the title Update/remove security settings Remove Settings > Security menu item for wpcom atomic sites Jan 16, 2025
@lsl lsl added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Team Review labels Jan 16, 2025
Copy link
Member

@okmttdhr okmttdhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this with Atomic Default site, and it worked well both in wp-admin and Calypso!

p1737072183699669/1736918927.990999-slack-CRWCHQGUB

@lsl lsl merged commit 3c7e4f4 into trunk Jan 17, 2025
63 checks passed
@lsl lsl deleted the update/remove-security-settings branch January 17, 2025 00:55
@github-actions github-actions bot removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Needs Team Review labels Jan 17, 2025
coder-karen pushed a commit that referenced this pull request Jan 24, 2025
* Remove Settings > Security menu item from atomic sites menu

* changelog

* Remove duplicate function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Package] Masterbar [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants