-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart Library: add bar chart component tests + improve data validation #41296
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
projects/js-packages/charts/src/components/bar-chart/bar-chart.tsx
Outdated
Show resolved
Hide resolved
projects/js-packages/charts/src/components/bar-chart/bar-chart.tsx
Outdated
Show resolved
Hide resolved
projects/js-packages/charts/src/components/bar-chart/bar-chart.tsx
Outdated
Show resolved
Hide resolved
b83e375
to
68131f4
Compare
@@ -38,6 +38,10 @@ const BarChart: FC< BarChartProps > = ( { | |||
const { tooltipOpen, tooltipLeft, tooltipTop, tooltipData, hideTooltip, showTooltip } = | |||
useTooltip< BarChartTooltipData >(); | |||
|
|||
const handleMouseLeave = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wrapper doesn't feel to do anything, so I removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Did a minor change to remove unnecessary code, hope you don't mind 😄
🚢
Code Coverage SummaryCoverage changed in 3 files.
|
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Verify that tests run successfully and pass.
In your Jetpack local env, navigate to the Storybook development environment:
Find
JS Packages/Charts/Bar Chart
in the sidebar then navigate down toError States
to check the possible error states