-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove customization for hiding Core's start page options modal #41324
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I can confirm that the dotcom page starter modal still works fine after this change. However, I didn't check whether it fully resolves Automattic/wp-calypso#98892 (needs @triple0t 's help to verify)
I tested on my WoA site and can confirm this PR resolves the issue. |
Related to
core/post-content
is stripped out of registered patternsblockTypes
property for WPCOM sites wp-calypso#98892Proposed changes:
Remove
update_pattern_block_types
since;core/post-content
is stripped out of registered patternsblockTypes
property for WPCOM sites wp-calypso#98892update_pattern_block_types
only.See p1737695864171759/1737538662.329279-slack-C03N25JPCE4 for more context.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: