Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/themes url to wpadmin #41376

Draft
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Draft

Update/themes url to wpadmin #41376

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e54e7b5
Remove mapping to Calypso URLs for Themes
getdave Jan 28, 2025
e35529e
changelog
getdave Jan 28, 2025
f87edec
Remove debug
getdave Jan 29, 2025
c0e3ada
Update projects/packages/masterbar/src/admin-menu/class-admin-menu.php
getdave Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/packages/masterbar/changelog/update-themes-url-to-wpadmin
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: changed

Update Themes page URL to go to WPAdmin view
11 changes: 5 additions & 6 deletions projects/packages/masterbar/src/admin-menu/class-admin-menu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
* Create the desired menu output.
*/
public function reregister_menu_items() {

getdave marked this conversation as resolved.
Show resolved Hide resolved
// Remove separators.
remove_menu_page( 'separator1' );
$this->add_stats_menu();
Expand Down Expand Up @@ -295,9 +296,7 @@
$default_customize_background_slug_2 => add_query_arg( array( 'autofocus' => array( 'section' => 'colors_manager_tool' ) ), $customize_url ),
);

if ( self::DEFAULT_VIEW === $this->get_preferred_view( 'themes.php' ) ) {
$submenus_to_update['themes.php'] = 'https://wordpress.com/themes/' . $this->domain;
}
l( 'Themes remap removed' );

Check failure on line 299 in projects/packages/masterbar/src/admin-menu/class-admin-menu.php

View workflow job for this annotation

GitHub Actions / Static analysis 

UndefError PhanUndeclaredFunction Call to undeclared function \l()

Suggestion: Did you mean \Automattic\Jetpack\Masterbar\load_bootstrap_on_init() or \Automattic\Jetpack\Masterbar\load_the_user_profile_info_revert()

FAQ on Phan issues: pdWQjU-Jb-p2
getdave marked this conversation as resolved.
Show resolved Hide resolved

$this->update_submenus( 'themes.php', $submenus_to_update );

Expand Down Expand Up @@ -499,15 +498,15 @@
<div class="upsell_banner">
<div class="banner__info">
<div class="banner__title">
<?php echo wp_kses( $nudge['content'], array() ); ?>
<?php echo wp_kses( $nudge['content'], array() ); ?>
</div>
</div>
<div class="banner__action">
<button type="button" class="button">
<?php echo wp_kses( $nudge['cta'], array() ); ?>
<?php echo wp_kses( $nudge['cta'], array() ); ?>
</button>
</div>
<?php if ( $nudge['dismissible'] ) : ?>
<?php if ( $nudge['dismissible'] ) : ?>
<svg xmlns="http://www.w3.org/2000/svg" data-feature_class="<?php echo esc_attr( $nudge['feature_class'] ); ?>" data-feature_id="<?php echo esc_attr( $nudge['id'] ); ?>" viewBox="0 0 24 24" class="gridicon gridicons-cross dismissible-card__close-icon" height="24" width="24"><g><path d="M18.36 19.78L12 13.41l-6.36 6.37-1.42-1.42L10.59 12 4.22 5.64l1.42-1.42L12 10.59l6.36-6.36 1.41 1.41L13.41 12l6.36 6.36z"></path></g></svg>
<?php endif; ?>
</div>
Expand Down
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/update-themes-url-to-wpadmin
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: enhancement

Changed Themes URL to be WPAdmin
4 changes: 4 additions & 0 deletions projects/plugins/mu-wpcom-plugin/changelog/update-themes-url-to-wpadmin
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: changed

Updates Themes URL to point to WPAdmin
4 changes: 4 additions & 0 deletions projects/plugins/wpcomsh/changelog/update-themes-url-to-wpadmin
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: changed

Updates Themes URL to point to WPAdmin
Loading