-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev Docker: add php extensions needed for unit testing and code coverage #41409
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
DEBIAN_FRONTEND=noninteractive \ | ||
PNPM_HOME=/usr/local/pnpm \ | ||
PATH="/usr/local/pnpm:${PATH}" \ | ||
npm_config_update_notifier=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update the PR description. This snuck in. It's to disable the prompt to update pnpm
when running jp
commands. Since each container is destroyed after use, even if someone updated pnpm
within the docker container, the image would still have 9.15.0.
I struggled to find documentation of this related to pnpm, but npm added it via npm/cli#1632 and pnpm claims to follow npm's update notification framework. In testing, it seemed to work. At worst, it does nothing.
tools/docker/Dockerfile.monorepo
Outdated
@@ -8,28 +8,31 @@ ARG PNPM_VERSION | |||
|
|||
ENV LANG=en_US.UTF-8 \ | |||
LC_ALL=en_US.UTF-8 \ | |||
JETPACK_MONOREPO_ENV=1 | |||
JETPACK_MONOREPO_ENV=1 \ | |||
DEBIAN_FRONTEND=noninteractive \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want DEBIAN_FRONTEND
set inside the image itself? From https://docs.docker.com/reference/dockerfile/#env
Environment variable persistence can cause unexpected side effects. For example, setting
ENV DEBIAN_FRONTEND=noninteractive
changes the behavior ofapt-get
, and may confuse users of your image.If an environment variable is only needed during build, and not in the final image, consider setting a value for a single command instead:
RUN DEBIAN_FRONTEND=noninteractive apt-get update && apt-get install -y ...
Or using ARG, which is not persisted in the final image:
ARG DEBIAN_FRONTEND=noninteractive RUN apt-get update && apt-get install -y ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it!
…age (#41409) * Add additional ext needed for WordPress [unit testing] and code coverage * Other additions from 41057 originally * condense the build steps in attempt to make building more reliable * Move pnpm_home declaration to avoid docker build warning * Update needed packages * Re-allow rec packages
The new Dev Docker container need additional php extensions for WordPress (for unit testing/WorDBless) and code coverage.
Proposed changes:
npm_config_update_notifier
env var to prevent PNPM from alerting to update the in-docker pnpm version.Other information:
Jetpack product discussion
#41057 (comment)
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
BUILD_LOCAL=1 jp test php packages/image-cdn -v
BUILD_LOCAL=1 jp test coverage packages/image-cdn
(or any other package with PHP code coverage.