Fix/crm/js issue welcome wizard - WIP

[mikestottuk]

Fixes Automattic/zero-bs-crm#3531

Proposed changes:

Some of the variables in the JS were set like so window.variable = { } and these were changed to be const variable = { } however in some places the window.variable references remained.

This causes some JS errors in local installs.

Other information:

• Have you written new tests for your changes, if applicable? N/A
• Have you checked the E2E test CI results, and verified that your changes do not break them? N/A
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)? N/A

Jetpack product discussion

Discussed via p1738254853764999-slack-C052XEUUBL4

Does this pull request change what data or activity we track or use?

No

Testing instructions:

• Git pull the trunk
• Going to a page like this wp-admin/admin.php?page=zerobscrm-dash&jpcrm_force_wizard=true will force the wizard to show (in case you have already run it)
• Run through the welcome wizard. The "finish" step will be broken
• Pull this branch, the "finish" step works again

It does not impact the live version, likely because of the minimisation step

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

[github-actions]

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report

[tbradsha]

Previously only the minified version worked, and now minified and unminified work. Looks good to me!