Remove overwrite option for updateOne(), findOneAndUpdate(), etc.
#13989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndUpdate to findOneAndReplace Re: #13578
vkarpov15
requested review from
Uzlopak,
hasezoey,
AbdelrahmanHafez and
IslandRhythms
vkarpov15
changed the title
overwrite option for updateOne(), findOneAndUpdate(), etc.
IslandRhythms
approved these changes
Oct 17, 2023
hasezoey
requested changes
Oct 18, 2023
There was a problem hiding this comment.
LGTM, but there are some things missing:
remove(seems like optionoverwriteoption from typescript typesoverwritenever even existed in the types)- add changelog entry about removal
the current typescript types ci failing is not related to this PR, it has been introduced into the 8.0 branch by 81cba56
|
@hasezoey can you re-review please? |
hasezoey
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re: #13578, remove the
overwriteoption for 8.0. In 7.x,Model.findOneAndUpdate(filter, update, { overwrite: true })becomes afindOneAndReplace(), which is a vestigial quirk of back whenupdate()with no atomic operators would overwrite the document. Given that's no longer the case, we don't really need anoverwriteoption anymore.Removed a few tests that relied on
overwrite: true.Examples