Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint for Spacing #3376

Merged
merged 2 commits into from
Sep 16, 2015
Merged

Lint for Spacing #3376

merged 2 commits into from
Sep 16, 2015

Conversation

ChristianMurphy
Copy link
Contributor

used eslint . --fix to resolve the warnings automatically 😄

@ChristianMurphy
lint for spacing
2965872 
use ESLint --fix to resolve the warnings automatically
@vkarpov15
Copy link
Collaborator

Can we make it so that function() {} is the accepted convention instead of function () {}, no space between function and ()?

@ChristianMurphy
Copy link
Contributor Author

@vkarpov15 absolutely!
Updated the configuration and the code.

@vkarpov15 vkarpov15 added this to the 4.1.8 milestone Sep 16, 2015
vkarpov15 added a commit that referenced this pull request Sep 16, 2015
@vkarpov15
Merge pull request #3376 from ChristianMurphy/lint-for-spacing
e56a713 
Lint for Spacing
@vkarpov15 vkarpov15 merged commit e56a713 into Automattic:master Sep 16, 2015
@ChristianMurphy ChristianMurphy deleted the lint-for-spacing branch September 23, 2015 00:47
@ChristianMurphy ChristianMurphy mentioned this pull request Feb 1, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.8
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristianMurphy @vkarpov15