-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spellchecker (electron-spellchecker) #821
Conversation
yup, I will update the file/folder names.
I'm planning to add the same approach using Also, I'm planning a PR that is simplifying debugging when we are in dev mode like introducing keyboard shortcuts for showing dev tools, ... |
cc5255e
to
f9de260
Compare
@mirka @roundhill the required changes were made. Plus,
I'm going to test everything once more and then we should be done here. |
|
||
.PHONY: rebuild-deps | ||
rebuild-deps: | ||
@npx electron-rebuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked great 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TagList is showing a context menu when it shouldn't, but it was a markup problem (#844) and not a problem with this spellchecker PR.
Works great, thank you!
This is an alternative approach to #753 that is using electron-spellchecker.
I'm extending some electron-spellchecker classes to provide more flexibility and to mimic the setup of #753
This PR introduces the new make targets:
make dev
: starting the webpack dev servermake start
: start electron and check if a native dependency rebuild is necessarymake rebuild-deps
: rebuilds native dependencies. This is a dependency ofmake start