Multiple themes: Double-check quote styles with GB 5.2

[laurelfulford]

The Quote block is going to get a bit of a style refresh in a future release of Gutenberg (5.2, milestoned for March 4th). If the block's text is either left or right aligned, a border is added to that side of the block:

WordPress/gutenberg#13248

This can potentially cause visual issues if a theme already has a side border defined for this block. So we need to double-check the themes that have Gutenberg styles, to see if there are any clashes, and proactively fix them.

Themes to check:

• Affinity - fine on front-end, but in editor, centred is missing top and bottom borders, and right aligned has an extra right border. - fixed in Affinity: Update quote block border styles #606 and r53376-wpcom-themes.
• Altofocus - no border
• Apostrophe 2 - on front-end, all alignments have a left border; might be good to line this up with Twenty Nineteen (which has a border the side the text is aligned to, or none for centred). In editor, has extra right border. - fixed in Apostrophe 2: Update quote block border styles #607 and r53377-wpcom-themes
• Button 2 - no border
• Calm Business - same issues as Twenty Nineteen, same on front-end and in editor - fixed in Calm Business: Update quote block border styles #599 and r53370-wpcom-themes.
• Canard - extra right border in editor. - fixed in Canard: Update quote block border styles #608 and r53378-wpcom-themes.
• Dara - looks fine with this update (but has quote icon always on left) - fixed in Dara: Align quote icon to right when text is right aligned #617 and r53390-wpcom-themes.
• Dyad 2 - extra right border in editor and on front end. - fixed in Dyad 2: Update quote block border styles #609 and r53379-wpcom-themes
• Elegant Business - same issues as Twenty Nineteen, in editor and on front-end - fixed in Elegant Business: Update quote block border styles #600, r53371-wpcom-themes
• Friendly Business - same issues as Twenty Nineteen, in editor and on front-end - fixed in Friendly Business: Update quote block border styles #602 and r53372-wpcom-themes.
• Gazette - looks fine with this update (but has quote icon always on left) - fixed in Gazette: Align quote icon to right when text is right aligned #618 and r53391-wpcom-themes
• Illustratr - on front-end, all alignments have a left border; might be good to line this up with Twenty Nineteen. In editor, has extra right border. - fixed in Illustratr: Update quote block border styles #619 and r53392-wpcom-themes.
• Independent Publisher 2 - border is always on left - fixed in Independent Publisher 2: Update quote block border styles #610 and r53380-wpcom-themes.
• Intergalactic 2 - no border
• Ixion - no border
• Karuna - no border
• Libre 2 - looks fine with this update (but has quote icon always on left) - fixed in Libre 2: Align quote icon to right when text is right aligned #620 and r53393-wpcom-themes
• Libretto - looks fine with this update (but has quote icon always on left) - fixed in Libretto: Align quote icon to right when text is right aligned #621 and r53394-wpcom-themes
• Lodestar - on front-end, all alignments have a left border; might be good to line this up with Twenty Nineteen. In editor, has extra right border. - fixed in Lodestar: Update quote block border styles #611 and r53381-wpcom-themes.
• Modern Business - same issues as Twenty Nineteen, in editor and on front-end - fixed in Modern Business: Update quote block border styles #603 and r53373-wpcom-themes.
• Penscratch 2 - looks fine with this update (but has quote icon always on left) - fixed in Penscratch 2: Align quote icon to right when text is right aligned #622 and r53395-wpcom-themes
• Photos - border should be on right on front-end; has double-border in editor on right-aligned quotes. - fixed in Photos: Update quote block border styles #612 and r53383-wpcom-themes
• Pique - not affected by update, but quote icon is aligned left/right on front end but always centred in editor - fixed in Pique: Align quote icon to center when text is right aligned #623 and r53396-wpcom-themes
• Professional Business - same issues as Twenty Nineteen, in editor and on front-end - fixed in Professional Business: Update quote block border styles #604 and r53374-wpcom-themes.
• Publication - has borders on top and bottom; update doesn't have adverse effects
• Radcliffe 2 - has borders on top and bottom; update doesn't have adverse effects
• Rebalance - border always on left on front-end, and extra right border on right in editor - fixed in Rebalance: Update quote block border styles #613 and r53386-wpcom-themes
• Scratchpad - looks fine with this update (but has quote icon always on left) - fixed in Scratchpad: Align quote icon to right when text is right aligned #624 and r53397-wpcom-themes
• Shoreditch - no change with this update, but border is always on left - fixed in Shoreditch: Update quote block border styles #614 and r53387-wpcom-themes
• Sketch - border always on left on front-end; has extra right border in editor - fixed in Sketch: Update quote block border styles #615 and r53388-wpcom-themes
• Sophisticated Business - same issues as Twenty Nineteen, in editor and on front-end (though extra border is hard to see against the dark background) - fixed in Sophisticated Business: Update quote block border styles #605 and r53375-wpcom-themes.
• Textbook - no border
• Toujours - border is always on left; has extra double border on right in editor - fixed in Toujours: Update quote block border styles #616 and r53389-wpcom-themes.

It's important to note that this did cause an issue with Twenty Nineteen so any of its child themes will likely have the same problem; it will need to be fixed in each of those themes individually, since the styles aren't inherited from the parent theme.

[laurelfulford]

Note that the color-patterns.php changes being added to Twenty Nineteen need to be synced up with the WP.com version after they're committed, to be made available in the style variations themes (Calm, Elegant, Friendly, Modern, Professional & Sophisticated). But the CSS/Sass updates can be added to each theme now.

[laurelfulford]

These should all be taken care of now.