Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The deploy-dotorg GH action fails if there is an error with a single theme #7936

Closed
mikachan opened this issue Jul 8, 2024 · 0 comments · Fixed by #8020
Closed

[Bug]: The deploy-dotorg GH action fails if there is an error with a single theme #7936

mikachan opened this issue Jul 8, 2024 · 0 comments · Fixed by #8020

Comments

@mikachan
Copy link
Member

mikachan commented Jul 8, 2024

Quick summary

The deploy-dotorg GH action seems to be failing here: https://github.com/Automattic/themes/actions/runs/9837238698/job/27154613541.

It fails with this error: sed: can't read s/, auto-loading-homepage//g: No such file or directory

We could update the script so that it skips over themes that cause an error, so that the script can continue rather than exiting out.

Steps to reproduce

Run the deploy-dotorg GH action.

What you expected to happen

I would expect the script to continue to run over all possible themes rather than exiting on the first error.

What actually happened

The script exited and therefore stopped on the first error.

Browser

No response

Context

No response

Platform (Simple, Atomic, or both?)

No response

Other notes

No response

Reproducibility

Consistent

Severity

None

Available workarounds?

None

Workaround details

No response

@mikachan mikachan added [Type] Bug Something isn't working Automation labels Jul 8, 2024
@mikachan mikachan changed the title [Bug]: The deploy-dotorg GH action fails if a theme doesn't exist in the dotorg directory [Bug]: The deploy-dotorg GH action fails if there is an error with a single theme Jul 8, 2024
@mrfoxtalbot mrfoxtalbot moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants