-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update theme foam #7860
Update theme foam #7860
Conversation
- Add missing side padding to header Also exported as a zip file. * [Preview loaded from this PR – available **before** this PR is merged](https://playground.wordpress.net/?import-site=https%3A%2F%2Fraw.githubusercontent.com%2Fautomattic%2Fthemes%2Fplayground-changes-2024-06-17T13-49-20-041Z%2Ffoam%2Fplayground.zip) * [Preview loaded from the main branch – available **after** this PR is merged](https://playground.wordpress.net/?import-site=https%3A%2F%2Fraw.githubusercontent.com%2Fautomattic%2Fthemes%2Ftrunk%2Ffoam%2Fplayground.zip)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mikachan I'm catching up on old PRs and skilling up so I can help. For this one, PR looks good, it's got a green check. But there's a failing test for "Preview theme changes". I tried restarting that check, but it failed again. Any tips for what to do in this situation? No rush. |
The failed PR preview is related to this, as @beafialho said. It's because we can't create the theme preview based on forks of a repo, due to security reasons. |
Oh thanks for chiming in. Does that mean we squas and merge despite the unsuccessful check? (That's what it sounds like!) |
Yep, it's fine to ignore this check for merging! |
Cool. @beafialho want to do the honors? |
@mikachan in case you have time again 🙏 — I'm also taking notes here. |
I think this is related to this action here: https://github.com/Automattic/themes/actions/runs/9837238698/job/27154613541 The "deploy to dotorg" GH action failed for Maverick: Pixel can take a look at improving this script so that it skips over themes that do not exist in the SVN repo yet, and make it so the script continues rather than exiting. Also, we could improve the error message above so that it's more obvious that the theme doesn't exist in the repo. Edit: I've opened an issue for this here: #7936 |
In this PR, the playground.zip was added to the theme; it was just an oversight, wasn't it? Otherwise, let me know. I'll make a PR to remove it from the theme before submission. |
Changes from WordPress Playground:
Also exported as a zip file.