Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update theme foam #7860

Conversation

beafialho
Copy link
Collaborator

Changes from WordPress Playground:

  • Add missing side padding to header

Also exported as a zip file.

Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasmussen
Copy link
Member

@mikachan I'm catching up on old PRs and skilling up so I can help. For this one, PR looks good, it's got a green check. But there's a failing test for "Preview theme changes". I tried restarting that check, but it failed again. Any tips for what to do in this situation? No rush.

@beafialho
Copy link
Collaborator Author

Related comment in #7928

@mikachan
Copy link
Member

mikachan commented Jul 5, 2024

Related #7928 (comment) in #7928

The failed PR preview is related to this, as @beafialho said. It's because we can't create the theme preview based on forks of a repo, due to security reasons.

@jasmussen
Copy link
Member

The failed PR preview is related to this, as @beafialho said. It's because we can't create the theme preview based on forks of a repo, due to security reasons.

Oh thanks for chiming in. Does that mean we squas and merge despite the unsuccessful check? (That's what it sounds like!)

@mikachan
Copy link
Member

mikachan commented Jul 8, 2024

Does that mean we squas and merge despite the unsuccessful check?

Yep, it's fine to ignore this check for merging!

@jasmussen
Copy link
Member

Cool. @beafialho want to do the honors?

@beafialho beafialho merged commit 61f7466 into Automattic:trunk Jul 8, 2024
2 of 3 checks passed
@beafialho
Copy link
Collaborator Author

I clicked Squash and Merge but I got this message in my email. What does this mean?

Captura de ecrã 2024-07-08, às 10 54 14

@jasmussen
Copy link
Member

@mikachan in case you have time again 🙏 — I'm also taking notes here.

@mikachan
Copy link
Member

mikachan commented Jul 8, 2024

I think this is related to this action here: https://github.com/Automattic/themes/actions/runs/9837238698/job/27154613541

The "deploy to dotorg" GH action failed for Maverick: sed: can't read s/, auto-loading-homepage//g: No such file or directory. I believe this is because the Maverick theme hasn't been submitted or launched on the dotorg directory yet. If the theme is ready to be launched, we could submit it here. If it's not ready to be launched, we should adjust this GH action script so that it can handle this better.

Pixel can take a look at improving this script so that it skips over themes that do not exist in the SVN repo yet, and make it so the script continues rather than exiting. Also, we could improve the error message above so that it's more obvious that the theme doesn't exist in the repo.

Edit: I've opened an issue for this here: #7936

@iamtakashi
Copy link
Contributor

In this PR, the playground.zip was added to the theme; it was just an oversight, wasn't it? Otherwise, let me know. I'll make a PR to remove it from the theme before submission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants