Review OutNow

[iamtakashi]

Quick summary

I'm reviewing the theme since we found out OutNow has not yet launched on dotcom.

@henriqueiamarino, here are my notes. Since the theme has already been launched on dotorg, I'll list the issues we can fix without disrupting the sites that already use it. Let me know your thoughts.

• I wouldn't recommend not having any column gaps because the text inside can bump each other.
• Featured images are overflowing on small screens. Since this bug remains, let's change this stack block to a regular group block and remove the height and the width specified for the featured image. That should stop the featured images from overflowing. The archives, the blog home, the index, and the search results templates share this issue.
• It'd look better if the side paddings match all the way. All the templates share this issue.
• Add the usual no-results block to the archive, blog home, index, and search results templates.
• The logo(?) bumps the browser window.
• The alignment could be better on 404.
• The alignment could be better.
• libre-franklin_italic_500.ttf and libre-franklin_normal_500.ttf don't seem to be registered in theme.json
• The file name seems dodgy for the Besley font in theme.json.
• Removeibm-plex-mono_italic_400.ttf, ibm-plex-mono_italic_600.ttf, ibm-plex-mono_normal_400.ttf, and ibm-plex-mono_normal_600.ttf they are not used in the theme.
• Let's list all the template parts with a title in theme.json
• Remove the unused patterns, patterns/comments.php, patterns/front-page.php, and patterns/hidden-no-results-content.php
• The flamboyant.json and herbivore.json have font registrations, but if they are already registered in the main theme.json, we can safely remove that from each style.
• Let's update the Tested up to: to 6.7 in the readme.txt and style.css
• Let's update the Requires PHP: to 7.0 in the readme.txt and style.css
• Let's change the Version: to 1.3.0
• Let's remove the following theme tags, entertainment, four-columns, block-patterns, custom-background, custom-colors, custom-header, custom-logo, custom-menu, editor-style, flexible-header, post-formats, sticky-post, template-editing, theme-options.
• Instead, add three-columns
• I know this is a Gutenberg issue, but let's edit the label for the font size presets.
• I can see many cases of using numeric font sizes in the theme; try searching fontSize in the theme folder. While this will impact the theme's usability, we don't want to change the presets' sizes drastically because this theme has already been launched. The ones in similar sizes could change to use one of the presets, but you might need to add new presets for some cases.

Steps to reproduce

A clear and concise description of what you expected to happen.

No response

What actually happened

No response

Impact

All

Available workarounds?

Yes, difficult to implement

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

No response

Logs or notes

No response

[Robertght]

Since this is a pre-launch theme review, I'm assigning this as Triged on the One Board, so feel free to do the same for newer similar reports @iamtakashi. Thanks!