Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seedlet: add Jetpack subscription block styling #3018

Merged
merged 2 commits into from
Jan 14, 2021

Conversation

jffng
Copy link
Contributor

@jffng jffng commented Jan 13, 2021

This PR addresses #2913 and #3012.

Before

Seedlet Spearhead
Screen Shot 2021-01-13 at 10 04 07 AM Screen Shot 2021-01-13 at 10 04 23 AM

After

Seedlet Spearhead
Screen Shot 2021-01-13 at 10 03 47 AM Screen Shot 2021-01-13 at 10 00 03 AM

@scruffian
Copy link
Member

Do you think this should live in the Block itself?

@jffng
Copy link
Contributor Author

jffng commented Jan 13, 2021

I don't think the block should have to absorb these rules.

Both rules that added in this PR are a result of Seedlet's form styles not playing nicely with the block's default styles.

Copy link
Member

@scruffian scruffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scruffian scruffian merged commit 0609ff9 into trunk Jan 14, 2021
@scruffian scruffian deleted the fix/subscriptions-block-input branch January 14, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants