Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the featured image to center, not full. #3871

Closed
wants to merge 1 commit into from

Conversation

jffng
Copy link
Contributor

@jffng jffng commented May 17, 2021

Fixes #3805.

Before After
Screen Shot 2021-05-17 at 12 24 29 PM Screen Shot 2021-05-17 at 12 24 10 PM

@jffng jffng requested review from kjellr and a team May 17, 2021 16:25
@jffng jffng added this to the Quadrat v1 milestone May 17, 2021
@kjellr
Copy link
Contributor

kjellr commented May 17, 2021

I don't think this fixes it — we'd like our featured images to be full-width, but we also want them to actually extend to the edges of the screen. Right now when they're alignfull, they don't go all the way to the edges like an alignfull image would.

@jffng
Copy link
Contributor Author

jffng commented May 17, 2021

@kjellr

This PR does allow the featured image to extend to edges of the screen, so long as its intrinsic width is greater than or equal to the window size:

Screen Shot 2021-05-17 at 4 56 48 PM

Are you suggesting that the featured image should always stretch to fullscreen, even if its width is smaller than the browser viewport?

@kjellr
Copy link
Contributor

kjellr commented May 18, 2021

Are you suggesting that the featured image should always stretch to fullscreen, even if its width is smaller than the browser viewport?

Yeah, that would match the "alignfull" behavior of all other blocks.

@jffng
Copy link
Contributor Author

jffng commented May 18, 2021

Closing this, as it should be addressed upstream.

@jffng jffng closed this May 18, 2021
@scruffian scruffian deleted the fix/quadrat-featured-image branch May 19, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quadrat: Featured Image doesn't extend full-width if the image is small
2 participants