Create Pendant Base Theme #5694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jffng
reviewed
Mar 16, 2022
| @@ -0,0 +1,15 @@ | |||
| <?php | |||
| /** | |||
| * Pattern Name: A 404 page | |||
There was a problem hiding this comment.
We don't register this so an empty pattern shows up in the site editor. I think it's fine to do this in a follow-up, unless you wanted to do it now...
There was a problem hiding this comment.
We're still waiting for this to land at which point this should start working. It doesn't work now but I hope it will before we start in on patterns (and the 404 page). This was copied from @MaggieCabrera 's new boilerplate theme.
My 'druthers is to bring it in now.
There was a problem hiding this comment.
The pattern PR in GB is going to be merged soon, and it most likely will make it to dotcom before the theme is ready to launch, but we can of course make a patch in the meantime.
Co-authored-by: Jeff Ong <[email protected]>
Co-authored-by: Jeff Ong <[email protected]>
Co-authored-by: Jeff Ong <[email protected]>
jffng
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloned 'Block Canvas' via the Create Block Theme plugin and adjusted the palette colors as a starting point for Pendant.
This closes #5683
This also closes #5688
Currently this looks a LOT like Blockbase. That is expected.