-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brute: add theme #7876
Brute: add theme #7876
Conversation
Preview changesI've detected changes to the following themes in this PR: Brute. You can preview these changes by following the links below: I will update this comment with the latest preview links as you push more changes to this PR. |
I've found some issues with the theme:
|
@alaczek, I have fixed the following issues on the latest commit:
|
I made a little fix with the |
@MaggieCabrera, I provided the credits for all the images I use on the homepage. While two of them are packed within the theme, just one is shown on the screenshot. Should I credit only that one? This confuses me sometimes... screenshot is fine, updated. |
I think your commit removed my changes |
And about the credits: you don't need to credit what's on the demo site, only what you can see when you install the theme fresh from these files, that means:
And of course we shouldn't load images externally, they should be packaged in the assets files |
Oh no, sorry about that, @MaggieCabrera. Before doing so, I checked the Update Branch button as you instructed me 😔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@MaggieCabrera, here's the demo content file. |
Brute is a theme design inspired by the Brutalist concepts of the homonymous Architectural movement. It aims to be harsh, honest, utilitarian, and useful. It is a good portfolio pick for architects, design studios, and creative organizations.
Demo site