-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Margarethe: Add new theme #8083
Conversation
Preview changesI've detected changes to the following themes in this PR: Margarethe. You can preview these changes by following the links below: I will update this comment with the latest preview links as you push more changes to this PR. |
This one is ready for review, it should be ready to submit to dotorg |
@MaggieCabrera I checked the following items, and they are all LGTM:
I found only two topics that can be problematic: Theme Check alerted us about these three images that can be compacted:
The Theme URI doesn't follow our standards. We have been using showcase pages on the Themeshaper site. So, this theme's page should be: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. The only thing I flagged is the size of some of the images - I don't know what's the recommended size, but I think anything over 350-400KB needs to be compressed.
I made the changes to the images and the theme URL, I'm bringing this in, thanks for the reviews! |
pNEWy-hXf-p2