Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamer: fixes Plunge style variation #8453

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

henriqueiamarino
Copy link
Collaborator

This PR fixes the units used on the H1s of a style variation. The (Virtual Height) VH values were causing the theme preview to break, but they are now fixed.

Copy link
Contributor

Preview changes

I've detected changes to the following themes in this PR: Streamer.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link
Contributor

Theme-Check results

streamer: No changes required ✅.


@iamtakashi
Copy link
Contributor

Looks good to me 🚢 !

@henriqueiamarino henriqueiamarino merged commit 618ec9c into trunk Nov 25, 2024
4 checks passed
@henriqueiamarino henriqueiamarino deleted the update/streamer-plunge-variation branch November 25, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants