Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static links in GrammerOne #8538

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Fix static links in GrammerOne #8538

wants to merge 1 commit into from

Conversation

dsas
Copy link
Contributor

@dsas dsas commented Dec 16, 2024

See #8252

Changes proposed in this Pull Request:

Related issue(s):

Copy link
Contributor

Preview changes

I've detected changes to the following themes in this PR: Grammer One.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link
Contributor

Theme-Check results

grammerone: No changes required ✅.

⚠️ WARNING (2)
  • screenshot.png is 1.1 MB in size. Large file sizes have a negative impact on website performance and loading time. Compress images before using them.
  • Your theme appears to be in the wrong directory for the theme name. The directory name must match the slug of the theme. This theme's correct slug and text-domain is grammer-one. (If this is a child theme, you can ignore this error.)
💡 RECOMMENDED (1)
  • Tested up to is recommended to have major versions only (e.g. 5.8). Patch version is not needed (e.g. 5.8.1).

Copy link
Contributor Author

@dsas dsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alaczek This change to Grammer-one makes sense to me. Grammer has nearly the exact same change to its headers, except it still hardcodes a tagline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants