Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitacora: Update Custom CSS for Subscription Block #8563

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

iamtakashi
Copy link
Contributor

@iamtakashi iamtakashi commented Jan 8, 2025

The theme no longer needs the custom CSS for the block, which was necessary to make the button the same height as the input field next to it. And the rule is currently breaking the height.

I noticed this while I was taking the dotcom support rotation.

Before After
CleanShot 2025-01-08 at 18 23 52@2x CleanShot 2025-01-08 at 18 21 58@2x

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Preview changes

I've detected changes to the following themes in this PR: Bitácora.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Theme-Check results

bitacora: No changes required ✅.

⚠️ WARNING (1)
  • Your theme appears to be in the wrong directory for the theme name. The directory name must match the slug of the theme. This theme's correct slug and text-domain is bit%c3%a1cora. (If this is a child theme, you can ignore this error.)

@iamtakashi iamtakashi merged commit b86fc93 into trunk Jan 8, 2025
3 checks passed
@iamtakashi iamtakashi deleted the update/bitacora-subscription branch January 8, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant