Actually bump minimum Parse.ly version to 3.15 in parsely.yml workflow (

#6071) * Actually bump minimum Parse.ly version to 3.15 in parsely.yml workflow * `track_authenticated_users` is `false` by default * fix: the order is `expected, actual` * fix: tests --------- Co-authored-by: Volodymyr Kolesnykov <[email protected]>
Automattic · Jan 6, 2025 · 1eae63a · 1eae63a
1 parent 60780fe
commit 1eae63a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/.github/workflows/parsely.yml b/.github/workflows/parsely.yml
@@ -23,8 +23,8 @@ jobs:
       matrix:
         config:
           # Oldest version of the parsely plugin
-          - { wp: latest, parsely: '3.5', mode: 'filter_enabled', php: '8.1' }
-          - { wp: latest, parsely: '3.5', mode: 'filter_disabled', php: '8.1' }
+          - { wp: latest, parsely: '3.15', mode: 'filter_enabled', php: '8.1' }
+          - { wp: latest, parsely: '3.15', mode: 'filter_disabled', php: '8.1' }
 
           # Latest version of the parsely plugin
           - { wp: latest, mode: 'filter_enabled', php: '8.1' }

diff --git a/tests/parsely/test-mu-parsely-integration.php b/tests/parsely/test-mu-parsely-integration.php
@@ -244,7 +244,7 @@ public function test_default_parsely_configs() {
 			'have_api_secret'              => false,
 			'is_javascript_disabled'       => false,
 			'is_autotracking_disabled'     => false,
-			'should_track_logged_in_users' => is_latest_version() ? false : true,
+			'should_track_logged_in_users' => false,
 			'tracked_post_types'           => array(
 				array(
 					'name'       => 'post',
@@ -337,13 +337,13 @@ public function test_parsely_configs_for_managed_mode() {
 		$configs = Parsely_Loader_Info::get_configs();
 
 		// Assert.
-		$this->assertEquals( $configs, array(
+		$this->assertEquals( array(
 			'is_pinned_version'            => has_filter( 'wpvip_parsely_version' ),
-			'site_id'                      => is_latest_version() ? 'site_id_value' : '',
-			'have_api_secret'              => is_latest_version() ? true : false,
+			'site_id'                      => 'site_id_value',
+			'have_api_secret'              => true,
 			'is_javascript_disabled'       => false,
 			'is_autotracking_disabled'     => false,
-			'should_track_logged_in_users' => is_latest_version() ? false : true,
+			'should_track_logged_in_users' => false,
 			'tracked_post_types'           => array(
 				array(
 					'name'       => 'post',
@@ -358,7 +358,7 @@ public function test_parsely_configs_for_managed_mode() {
 					'track_type' => 'do-not-track',
 				),
 			),
-		) );
+		), $configs );
 	}
 
 	public function test_alter_option_use_repeated_metas() {