Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpunit-docker: Suffix db and network with unique names #1906

Merged
merged 3 commits into from
Dec 15, 2020

Conversation

mjangda
Copy link
Member

@mjangda mjangda commented Dec 11, 2020

To avoid conflict with other containers, suffix the name of the tests network and the db database with a timestamp. Also remove the tests config and recreate it since our container names are now different with each run.

Checklist

n/a

Steps to Test

  1. ./bin/phpunit-docker.sh should now work properly when you're running vip-dev-env at the same time.

To avoid conflict with other repos, prefix the name of the tests network
and the db database with a timestamp.
@mjangda mjangda requested a review from a team as a code owner December 11, 2020 02:50
Copy link
Contributor

@pschoffer pschoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the change and it works great. It worked for me without the change as well though, the db container in my case when using vip-dev-env is vipdevlocal_database_1 for a local env.

I added a small note, but otherwise LGTM.

Cool, that you pinned the mariadb version!

bin/download-wp-tests.sh Outdated Show resolved Hide resolved
@mjangda
Copy link
Member Author

mjangda commented Dec 11, 2020

I tested the change and it works great. It worked for me without the change as well though, the db container in my case when using vip-dev-env is vipdevlocal_database_1 for a local env.

Thanks for testing. Looking at it again, I think the root problem was that I had an old, stale test config file that was breaking things so the rm is the most important thing in here. The container rename is just a bonus :)

Because we're deleting the file, it will never exist.
Copy link
Contributor

@pschoffer pschoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pschoffer pschoffer merged commit 616be40 into master Dec 15, 2020
@pschoffer pschoffer deleted the update/phpunit-docker branch December 15, 2020 08:47
@pschoffer
Copy link
Contributor

Code is not synced to SVN => no Deploy needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants