Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap blog public notices use of VIP_GO_APP_ENVIRONMENT in a defined check #1996

Merged

Conversation

brandon-m-skinner
Copy link
Contributor

Description

The new notice that your non-production site might be indexable by search engines throws a warning in CI and likely other places outside VIP Go where VIP_GO_APP_ENVIRONMENT isn't defined.

This PR wraps the usage of VIP_GO_APP_ENVIRONMENT in a defined check to avoid the warning and future error.

Changelog Description

Bug Fix: Fix warning thrown by blogpublic-notice.php when VIP_GO_APP_ENVIRONMENT isn't defined

We wrapped the usage of VIP_GO_APP_ENVIRONMENT in a defined check so it won't throw warnings anymore.

Checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally (or has an appropriate fallback).
  • This change works and has been tested on a Go sandbox.
  • This change has relevant unit tests (if applicable).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Steps to Test

  1. Run anything without VIP_GO_APP_ENVIRONMENT defined.
  2. Note the undefined constant warning.
  3. Apply the PR.
  4. Do 1 again.
  5. There shouldn't be an undefined constant warning anymore.

@brandon-m-skinner brandon-m-skinner requested a review from a team February 19, 2021 06:45
@brandon-m-skinner brandon-m-skinner merged commit 52a1a8a into master Feb 19, 2021
@brandon-m-skinner brandon-m-skinner deleted the fix/undefined_constant_warning_in_blogpublic_notice branch February 19, 2021 06:52
@brandon-m-skinner
Copy link
Contributor Author

r1396-stacks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants