Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vary-cache): allow for customizing cookie path and domain #5552

Merged
merged 1 commit into from
May 8, 2024

Conversation

sjinks
Copy link
Member

@sjinks sjinks commented May 8, 2024

Description

Fixes: #5531

Changelog Description

Added

It is now possible to customize the cookie path and domain for the cookies set by the Vary Cache plugin. To achieve that, we introduced two new filters: vip_vary_cache_cookie_path and vip_vary_cache_cookie_domain.

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
  • This change works and has been tested on a sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

See #5531.

Copy link

sonarqubecloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.43%. Comparing base (e52f028) to head (594f46d).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5552      +/-   ##
=============================================
+ Coverage      29.41%   29.43%   +0.02%     
  Complexity      4759     4759              
=============================================
  Files            281      281              
  Lines          20533    20523      -10     
=============================================
+ Hits            6039     6041       +2     
+ Misses         14494    14482      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjinks sjinks marked this pull request as ready for review May 8, 2024 19:31
@sjinks sjinks requested a review from a team as a code owner May 8, 2024 19:31
@rebeccahum rebeccahum merged commit a3fe7c9 into develop May 8, 2024
39 checks passed
@rebeccahum rebeccahum deleted the GH-5531 branch May 8, 2024 21:06
@rinatkhaziev rinatkhaziev added the [Status] Needs Docs Signal to Yoli the docs need to be updated label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to set vary cache for only single site with multisite architecture
3 participants