Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LYS badge override #1517

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Fix LYS badge override #1517

merged 2 commits into from
Sep 24, 2024

Conversation

ilyasfoo
Copy link
Contributor

@ilyasfoo ilyasfoo commented Sep 23, 2024

Changes proposed in this Pull Request:

Closes #1516

This PR fixes LYS badge style overridden by default admin color scheme.

I used nav-unification.css because I didn't want to add a new globally-loaded CSS for a mere couple lines fix.

Before

image image

After

image image

How to test the changes in this Pull Request:

  1. Use a WPCOM atomic e-commerce site
  2. Enable LYS feature flag (you can set these lines to true).
  3. Go to /wp-admin/profile.php
  4. Select Default admin color scheme and click Update Profile
  5. Hover the LYS badge
  6. Observe that it does not have a black background color
  7. Go to Settings > WooCommerce > Site visibility
  8. If it was Live, set to Coming soon, and vice versa. Click Save changes
  9. Hover the LYS badge
  10. Observe that it does not have a dark background color

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@ilyasfoo ilyasfoo requested review from a team, psealock and moon0326 September 23, 2024 13:16
Copy link

github-actions bot commented Sep 23, 2024

Size Change: 0 B

Total Size: 201 kB

ℹ️ View Unchanged
Filename Size
./build/53.js 1.08 kB
./build/index.css 878 B
./build/index.js 126 kB
./build/marketing.js 58.3 kB
./build/payment-gateway-suggestions.css 1.24 kB
./build/payment-gateway-suggestions.js 6.57 kB
./build/plugins.js 3.93 kB
./build/style-index.css 2.15 kB
./build/style-marketing.css 800 B

compressed-size-action

Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested well 👍 🚀

Copy link
Contributor

@psealock psealock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing well and selectors look good

@ilyasfoo ilyasfoo merged commit ec38584 into master Sep 24, 2024
5 checks passed
ilyasfoo added a commit that referenced this pull request Sep 24, 2024
ilyasfoo added a commit that referenced this pull request Sep 24, 2024
ilyasfoo added a commit that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Live badge hover background color overridden
3 participants