Update handling for PR as a country for terminal locations #10349
+66
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.29 MB ℹ️ View Unchanged
|
malinajirka
requested review from
kidinov
and removed request for
malinajirka
anu-rock
reviewed
Feb 11, 2025
There was a problem hiding this comment.
Code-only review: The change matches what Stripe expects. Thanks for slipping this in so quickly, @deepakpathania 🎉
Review checklist
| Parameter | Result |
|---|---|
| Approach | ✅ All good |
| Implementation | ✅ All good |
| Automated tests | ✅ All good |
| Naming | ✅ All good |
| Typing | ✅ All good |
| Code comments | ✅ All good |
| Changelog | ✅ All good |
| Documentation | Not applicable |
| PR description | ✅ All good |
| Testing instructions | We could expand it a little to inform how to test the API. |
| Manual testing |
tests/unit/admin/test-class-wc-rest-payments-terminal-locations-controller.php
Outdated
Show resolved
Hide resolved
anu-rock
approved these changes
Feb 11, 2025
…into update/terminal-controller-PR-country-handling
|
Thanks for this @deepakpathania, I don't see any difference in the response we get from the locations endpoint. To avoid creating a new store and onboarding via Puerto Rico I've tested this PR using the Jetpack Beta option, activating the
GET /wc/v3/wc_stripe/terminal/locations/store 200 ok GET /wc/v3/wc_stripe/connection_tokens 200 ok Which causes a 400 when we POST to |
|
Actually I see now the endpoint having I'm trying to create a jurassic ninja PR-based store following the setup here PdfdoF-D-p2 but despite following all the instructions, is restricted (Update WooPayments business details) and payments are disabled until I provide a Social Security Number, so I cannot test those with the reader. Could you provide credentials to a Puerto Rico-based store with functional WooCommerce Payments for testing? |
I think you could reach out to @malinajirka to assist with getting this setup. Or let me check if someone from the team can assist here. |
Thanks! I've tried a couple times and finally passed verification on a subsequent try. It seems we have a winner! It works 🎉 v1/terminal/locations/tml_F6lNlgv4nEj032 |
iamgabrielma
approved these changes
Feb 12, 2025
deepakpathania
deleted the
update/terminal-controller-PR-country-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10353
Changes proposed in this Pull Request
PRas a state andUSas the country in casePRis set as the country for the terminal locations endpoint.Testing instructions
PRas state andUSas country in casePRis the location.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge