Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Yoast Polyfill? #52

Closed
kraftbj opened this issue Apr 5, 2022 · 1 comment · Fixed by #61
Closed

Use Yoast Polyfill? #52

kraftbj opened this issue Apr 5, 2022 · 1 comment · Fixed by #61

Comments

@kraftbj
Copy link
Contributor

kraftbj commented Apr 5, 2022

When we extend using WorDBless as the base test class, we run into issues where we can't use SetupBeforeClass in a situation where we need cross-compat between various versions of PHP.

Yoast provides a polyfill, but I don't believe we use both at the same time. Would this be something WorDBless could/should do?

e.g. https://github.com/Yoast/PHPUnit-Polyfills#testcases
@kraftbj kraftbj mentioned this issue Apr 5, 2022
Merged
@szepeviktor
Copy link
Collaborator

we run into issues

Can be read here Automattic/jetpack#23687 (comment)

@kraftbj kraftbj mentioned this issue Feb 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Yoast PHPUnit Polyfill Automattic/wordbless
2 participants
@kraftbj @szepeviktor