-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Licensing: Move licensing endpoints to package #23687
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
At this point, the couple of outstanding items that I can think of are moving over tests to the new package and perhaps splitting off the endpoints to their own class. |
0267e58
to
6f8064e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick drive-by, hopefully this helps a bit.
projects/packages/licensing/tests/php/class-test-licensing-endpoints.php
Outdated
Show resolved
Hide resolved
79e4fc7
to
be844eb
Compare
9b9eb8b
to
e059c28
Compare
1982a4e
to
674bcb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I did a quick review of the code changes and they look reasonable to me. Furthermore, I thoroughly tested these flows manually and everything worked as expected.
Great! Thank you Renzo. I'll get it rebased and ready for a final review then 🙇♂️ |
…pack plugin to license package
102824e
to
1d7dd59
Compare
cfa74f6
to
1d7dd59
Compare
In preparation of moving licensing into the
my-jetpack
package, this pull request moves the licensing endpoints out of the Jetpack plugin and into thelicensing
package. This will then allow any consumer of thelicensing
package to use the endpoints without requiring the Jetpack plugin itself.Changes proposed in this Pull Request:
Jetpack product discussion
NA
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Newer licenses flow:
define( 'JETPACK_AUTOLOAD_DEV', true );
constant (I think 😄 )this_fails
Older partnership license flow:
add_filter( 'jetpack_licensing_ui_enabled', '__return_true' );
Note: The
licensing/user/licenses
doesn't appear to actually be used in the plugin? It is used in an action but I don't see that action being used anywhere.