-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for Users #33
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs another PR... |
leogermani
force-pushed
the
add/users_support
branch
from
November 23, 2020 14:22
cff4685
to
101bf2f
Compare
* add support for users * Upgrade CI (#34) from https://github.com/ergebnis/php-library-template * Upgrade shivammathur/setup-php in CI Co-authored-by: leogermani <[email protected]>
It is a brand new GitHub action
fix delete_option fix tests with wp_debug on
Now what? |
I'm working on real tests using this here -> Automattic/jetpack#17832 Let me experiment more with this and I'll probably find issues, as I already did |
szepeviktor
reviewed
Nov 25, 2020
szepeviktor
reviewed
Nov 30, 2020
Co-authored-by: Viktor Szépe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for users functions :)
Here is a non-exaustive list of functions supported:
wp_insert_user
wp_update_user
wp_delete_user
get_userdata
new WP_User( $id )
to fetch a useruser_can
current_user_can
set_current_user
get_current_user_id
wp_get_current_user
get_user_meta
update_user_meta
add_user_meta
delete_user_meta
Test instructions
Metadata.php
is just code moved around, disconsider)test-users.php
in the tests