-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve wp-content folder failure on install #54
Conversation
Actually the "Composer way" of doing this is having a static method. May I send a PR to this branch? |
Sure @szepeviktor , We are trying to figure out the failing tests on the lowest PHP 8.0. if you have any clues that is also welcome |
Yes, my L.A.S.E.R. eye 👁️ spotted the line below. wordbless/.github/workflows/ci.yaml Line 225 in 7798f6f
|
I'm sorry. I didn't remember my write access to this repo. |
I'm not a developer: more errors than keystrokes. |
Now 8.0, lowest installs these.
|
thanks @szepeviktor CI is still failing but I'm going to merge the PR as it is and open an issue for us to look at this later so we can unblock some other work depending on this |
roots/wordpress starting with version 5.9.4 no longer ships the wp-content folder. Previously, it would ship the entire WP install, inclusive of all default themes. It now only ships the "no-content" version. Wordbless install script assumed that wp-content dir would be present.
The intent, I believe, was for roots/wordpress to start doing that at 6.0, but they seemed to included 5.9.x starting with 5.9.4. Since we should update to 6.0+ anyhow, let's do both.