Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve wp-content folder failure on install #54

Merged
merged 14 commits into from
Sep 13, 2022
Merged

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Sep 13, 2022

roots/wordpress starting with version 5.9.4 no longer ships the wp-content folder. Previously, it would ship the entire WP install, inclusive of all default themes. It now only ships the "no-content" version. Wordbless install script assumed that wp-content dir would be present.

The intent, I believe, was for roots/wordpress to start doing that at 6.0, but they seemed to included 5.9.x starting with 5.9.4. Since we should update to 6.0+ anyhow, let's do both.

@szepeviktor
Copy link
Collaborator

szepeviktor commented Sep 13, 2022

Actually the "Composer way" of doing this is having a static method.
"post-update-cmd": "WorDBless\\Composer\\InstallDropin::copy"

May I send a PR to this branch?

@leogermani
Copy link
Collaborator

Sure @szepeviktor ,

We are trying to figure out the failing tests on the lowest PHP 8.0. if you have any clues that is also welcome

@szepeviktor
Copy link
Collaborator

We are trying to figure out the failing tests on the lowest PHP 8.0. if you have any clues that is also welcome

Yes, my L.A.S.E.R. eye 👁️ spotted the line below.

composer require --no-update --no-interaction --no-progress --no-suggest --dev 'phpunit/phpunit:^6.5 || ^7.5 || ^9.0'

@szepeviktor
Copy link
Collaborator

szepeviktor commented Sep 13, 2022

I'm sorry. I didn't remember my write access to this repo.

@szepeviktor
Copy link
Collaborator

I'm not a developer: more errors than keystrokes.
Although I'm good at thinking about long-term things.

@szepeviktor
Copy link
Collaborator

szepeviktor commented Sep 13, 2022

Now 8.0, lowest installs these.

  - Installing roots/wordpress-core-installer (1.0.0): Downloading (100%)
  - Installing roots/wordpress-no-content (6.0.2): Downloading (100%)
  - Installing roots/wordpress (6.0.2)
  - Installing sebastian/version (3.0.2): Downloading (100%)
  - Installing sebastian/type (2.3.0): Downloading (100%)
  - Installing sebastian/resource-operations (3.0.3): Downloading (100%)
  - Installing sebastian/recursion-context (4.0.2): Downloading (100%)
  - Installing sebastian/object-reflector (2.0.2): Downloading (100%)
  - Installing sebastian/object-enumerator (4.0.3): Downloading (100%)
  - Installing sebastian/global-state (5.0.1): Downloading (100%)
  - Installing sebastian/exporter (4.0.3): Downloading (100%)
  - Installing sebastian/environment (5.1.3): Downloading (100%)
  - Installing sebastian/diff (4.0.3): Downloading (100%)
  - Installing sebastian/comparator (4.0.5): Downloading (100%)
  - Installing sebastian/code-unit (1.0.6): Downloading (100%)
  - Installing sebastian/cli-parser (1.0.1): Downloading (100%)
  - Installing phpunit/php-timer (5.0.2): Downloading (100%)
  - Installing phpunit/php-text-template (2.0.3): Downloading (100%)
  - Installing phpunit/php-invoker (3.1.1): Downloading (100%)
  - Installing phpunit/php-file-iterator (3.0.5): Downloading (100%)
  - Installing theseer/tokenizer (1.2.0): Downloading (100%)
  - Installing nikic/php-parser (v4.10.2): Downloading (100%)
  - Installing sebastian/complexity (2.0.0): Downloading (100%)
  - Installing sebastian/code-unit-reverse-lookup (2.0.2): Downloading (100%)
  - Installing sebastian/lines-of-code (1.0.0): Downloading (100%)
  - Installing phpunit/php-code-coverage (9.2.3): Downloading (100%)
  - Installing doctrine/instantiator (1.3.1): Downloading (100%)
  - Installing phpdocumentor/reflection-common (2.2.0): Downloading (100%)
  - Installing symfony/polyfill-ctype (v1.8.0): Downloading (100%)
  - Installing webmozart/assert (1.9.1): Downloading (100%)
  - Installing phpdocumentor/type-resolver (1.3.0): Downloading (100%)
  - Installing phpdocumentor/reflection-docblock (5.2.0): Downloading (100%)
  - Installing phpspec/prophecy (1.14.0): Downloading (100%)
  - Installing phar-io/version (3.0.2): Downloading (100%)
  - Installing phar-io/manifest (2.0.1): Downloading (100%)
  - Installing myclabs/deep-copy (1.10.1): Downloading (100%)
  - Installing phpunit/phpunit (9.5.0): Downloading (100%)  👈🏻 

@leogermani
Copy link
Collaborator

thanks @szepeviktor

CI is still failing but I'm going to merge the PR as it is and open an issue for us to look at this later so we can unblock some other work depending on this

@leogermani
Copy link
Collaborator

#55

@leogermani leogermani merged commit 208f2a1 into master Sep 13, 2022
@leogermani leogermani deleted the update/wordbless branch September 13, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants