Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing test under PHP8 and provide a fallback value for string #59

Merged
merged 3 commits into from
Oct 3, 2022
Merged

Fix failing test under PHP8 and provide a fallback value for string #59

merged 3 commits into from
Oct 3, 2022

Conversation

cezarpopa
Copy link
Contributor

Hi,

i believe this commit should fix the CI phpunit task from failing under php 8 and also will close #55

Thank you,
Cezar

szepeviktor
szepeviktor reviewed Sep 30, 2022
View reviewed changes
src/dbless-wpdb.php Outdated Show resolved Hide resolved
@cezarpopa @szepeviktor
Update src/dbless-wpdb.php
e72ea2c 
Co-authored-by: Viktor Szépe <[email protected]>
@szepeviktor
Copy link
Collaborator

Now CI says

Attempt to read property "post_type" on null

@cezarpopa
Copy link
Contributor Author

cezarpopa commented Oct 1, 2022 •
edited
Loading

Now CI says

Attempt to read property "post_type" on null

This should be fixed now, the culprit was that the type of $string was int in some cases.

@leogermani
Copy link
Collaborator

Thank you @cezarpopa !

@leogermani leogermani merged commit 8cd8d87 into Automattic:master Oct 3, 2022
@cezarpopa cezarpopa deleted the feature/fix-php-8-failing-test branch March 19, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szepeviktor szepeviktor szepeviktor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix CI
3 participants
@cezarpopa @szepeviktor @leogermani