Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mock method to override
$wpdb->db_server_info()
indbless-wpdb.php
.The purpose of this is to allow graceful execution of
dbDelta()
in WorDBless test cases.Currently, the
dbDelta
function calls$wpdb->db_server_info()
, which will end up callingmysql_get_server_info()
, which fatals. The reasonsmysql_get_server_info
breaks will either be due to the fact that it was removed in PHP 7.0.0, or if you're running an earlier version of PHP, because the method expects$wpdb->dbh
to not befalse
ornull
.Would this be a useful addition? While this doesn't necessarily add support for using
dbDelta
in WorDBless, it does prevent it from breaking when the function is executed inside a WorDBless test case.