-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to PHP 7.2 and WP 6.6 #67
base: trunk
Are you sure you want to change the base?
Conversation
Hmm, I'll need to dig into the CI since it looks like it assumes we're developing on an older version of PHP. |
|
@szepeviktor Can you walk me through the strict validation on the composer.lock/json file in the code standards test? Given that it doesn't happen with the locked unit test runs, I'm curious if it is needed, etc. Related, what version of PHP should the composer file be rendered with? I'm wondering if there is a specific PHP version that I need to target (beyond |
⛏️ Digging ... |
Modifying composer.json needs a lock file update. |
I realize that, but locally, there aren't any changes to composer.lock after running composer update. |
Co-authored-by: Viktor Szépe <[email protected]>
With WordPress 6.6+ requiring PHP 7.2 as a minimum, we can bump this up now.