Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to PHP 7.2 and WP 6.6 #67

Open
wants to merge 13 commits into
base: trunk
Choose a base branch
from
Open

Bump to PHP 7.2 and WP 6.6 #67

wants to merge 13 commits into from

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Jan 30, 2025

With WordPress 6.6+ requiring PHP 7.2 as a minimum, we can bump this up now.

@kraftbj
Copy link
Contributor Author

kraftbj commented Jan 30, 2025

Hmm, I'll need to dig into the CI since it looks like it assumes we're developing on an older version of PHP.

@szepeviktor
Copy link
Collaborator

  • Phive -> add A978220305CD5C32 to hashes
  • lock file -> you may be developing on PHP 8.1 and that generated the lock file

@kraftbj
Copy link
Contributor Author

kraftbj commented Jan 31, 2025

@szepeviktor Can you walk me through the strict validation on the composer.lock/json file in the code standards test? Given that it doesn't happen with the locked unit test runs, I'm curious if it is needed, etc.

Related, what version of PHP should the composer file be rendered with? I'm wondering if there is a specific PHP version that I need to target (beyond 7.3 or 7.4)?

@szepeviktor
Copy link
Collaborator

szepeviktor commented Jan 31, 2025

Given that it doesn't happen with the locked unit test runs,

composer validate runs only in the Coding Standards job.
But there is a warning there too https://github.com/Automattic/wordbless/actions/runs/13073688399/job/36480621792?pr=67#step:7:14

⛏️ Digging ...

@szepeviktor
Copy link
Collaborator

szepeviktor commented Jan 31, 2025

Modifying composer.json needs a lock file update.

@kraftbj
Copy link
Contributor Author

kraftbj commented Jan 31, 2025

Modifying composer.json needs a lock file update.

I realize that, but locally, there aren't any changes to composer.lock after running composer update.

composer.lock Outdated Show resolved Hide resolved
Co-authored-by: Viktor Szépe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants