Correct usage of UPLOADS with tests #73
Merged
+60
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I'm working with this in Automattic/jetpack#41765 to make sure it is functional in real usage. |
szepeviktor
previously approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #70, I missed that WordPress automatically combines ABSPATH and UPLOADS when using wp_upload_dir, so the tests created worked, but when actually needing to use the custom dir, it didn't.
Added a test that checked for the existence of the folder (which should happen in Load:load()) which failed when it was created UPLOADS and passed when creating ABSPATH.UPLOADS.