Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global Notices: some nice-to-haves #2958

Closed
6 tasks
rickybanister opened this issue Feb 1, 2016 · 1 comment
Closed
6 tasks

Global Notices: some nice-to-haves #2958

rickybanister opened this issue Feb 1, 2016 · 1 comment
Labels
Components [Status] Stale [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@rickybanister
Copy link

rickybanister commented Feb 1, 2016 •
edited by taggon
Loading

Initial work on making global notices into a nice floating pill-shape that doesn't interfere with the page flow has happened in #2413. They're already an improvement over what we currently have, but there are a few additional enhancements that will make them even more sweet.

  • style notice-action to allow for action links inside global notices (they should allow for gridicons as well)
  • allow more than one notice to stack up, rather than new notices replacing older ones—they should create a nice list
  • allow notices to have either a timeout (to be fully ephemeral, like for 'Saved!' notices)
  • or allow notices to be replaced by another notice (like 'Activating Plugin' => 'Plugin Activated')—they would have to be sub-grouped or something
  • More fun animation—take a cue from the Reader 'new posts' indicator and have the notices slide in from stage left, and fly out the same way
  • Convert the Reader 'new posts' indicator to be a global notice so it doesn't collide with them

cc @mtias
@rickybanister rickybanister added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it Components labels Feb 1, 2016
This was referenced Feb 1, 2016
Merged
Merged
taggon added a commit that referenced this issue Apr 17, 2016
@taggon
Global Notices: some nice to haves (#2958)
57ad57b 
- Allow notices to include an action link.
- Allow notices to have a timeout.
- Add 1px of top margin to a notice.
- Improve a bit of performance.
- New notice replaces the old one has the same ID.
- More than one notice will stack up.
- The Reader uses Global Notices for 'new posts' indicator.
- Update the design example to use redux action creators instead of old notice functions.
@taggon taggon mentioned this issue Apr 18, 2016
Closed
6 tasks
@stale
Copy link

stale bot commented Jan 11, 2018

This issue has been marked as stale because it hasn't been updated in a while. It will be closed in a week. If you would like it to remain open, can you please comment below and see what you can do to get things moving with this issue? Thanks! 🙏

@stale stale bot added the [Status] Stale label Jan 11, 2018
This was referenced Jun 29, 2021
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Components [Status] Stale [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rickybanister