Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE: Navigation Block inside footer breaks when set to display Header Navigation #71681

Closed
cuemarie opened this issue Jan 4, 2023 · 46 comments
Closed
Labels
[Closed] Not Reproducible Issue cannot be reproduced. Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Full Site Editor The site editor. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Interaction #] > 10 (Automated) interaction count label for better visibility. Please don't add these manualliy. Navigation Needs retest Flagged for retesting by Quality Engineering [Platform] Simple [Pri] High Address as soon as possible after BLOCKER issues [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Status] Fix Inbound Use when a fix is in unreleased component [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@cuemarie
Copy link

cuemarie commented Jan 4, 2023

Quick summary

Brand new simple site: Trying to set a navigation block inside the footer to display the "Header navigation" breaks the editor altogether.

Existing Sites: This is also impacting users with existing menus. We've had several users come to support today reporting that their footer menus are missing on the live site. We've found in all cases that the nav block in the Footer template part is not set to display the "Footer Navigation", but instead either the "header navigation", or a pre-existing menu.

Steps to reproduce

This issue is a little tough to replicate - I had best luck in a Free empty site, to avoid pre-existing menus.

  1. Create a free test site, which defaults to the theme Zoologist, and open the Site Editor.
  2. Add a navigation block to the site's footer - this will create a "Footer Navigation" menu.
  3. Next, add a page to the menu in the header - this will create a "Header Navigation" menu.
  4. Save your changes.
  5. Once you create a Header Navigation menu in your header, return to the footer, and try making the footer nav block display that menu as well.

What you expected to happen

I expected the navigation block in the footer to display the menu I'd built in the header.

What actually happened

The editor breaks, and returning to the editor I can't open the footer template part.

compressed.Screen.Capture.on.2023-01-04.at.11-38-09.mp4

From here, if I edit the Template Part itself, I can select the Header Navigation menu as my footer's nav block. When I return to the original template, though, it freezes again:

Screen.Capture.on.2023-01-04.at.11-56-05.mov

And on the live site, the footer's menu is now missing:

Markup 2023-01-04 at 11 58 18

Context

User reported here: 39301919-hc

They noted this issue was not happening yesterday. Discussion with other HEs encountering reports of the same issue here: p1672856428879729-slack-C03TY6J1A

Platform (Simple, Atomic, or both?)

Simple

Theme-specific issue?

FSE themes - replicated with Archeo and Zoologist, and user has reported with Tsubaki as well.

Browser, operating system and other notes

No response

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

Yes, easy to implement

Workaround details

Creating a new menu in the site footer can work around the issue.

@cuemarie cuemarie added [Type] Bug When a feature is broken and / or not performing as intended [Pri] High Address as soon as possible after BLOCKER issues Navigation User Report [Feature] Full Site Editor The site editor. labels Jan 4, 2023
@ClassicRKR27
Copy link

  • Another report here: 38151922-hc

@chad1008
Copy link
Contributor

chad1008 commented Jan 4, 2023

I've done some testing on this, and while I haven't yet identified exactly when it was introduced, it does look like the changes in the upcoming 14.9.x versions will address the issue.

If it hasn't already released on WPCOM before then, and/or if it's still an issue, I can work tomorrow on hunting down the preexisting introduction and fix for the bug - hopefully it's smooth sailing for affected users before then though! 😄

@cuemarie
Copy link
Author

cuemarie commented Jan 5, 2023

Another report here: 39338549-hc / 5841065-zd-woothemes (same user, just noting both for tracking

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

Support References

This comment is automatically generated. Please do not edit it.

@cuemarie
Copy link
Author

cuemarie commented Jan 6, 2023

For Future HE's encountering this, you can check out some internal discussion here p1672858930739649-slack-C02FMH4G to get a sense of some troubleshooting and timing on 14.9.x , which is expected to resolve this issue!

@liviopv
Copy link

liviopv commented Jan 6, 2023

  • 39356617-hc

@ccwalburn
Copy link

ccwalburn commented Jan 6, 2023

Another report here: 39368564-hc
Follow-up here:

  • 5843375-zen

The workaround of creating a new menu did not work.

@upwardmomentum84
Copy link

Similar issue here: 39357260-hc

The user had a second Nav block in their header. The first Nav block would show on the live version but the second Nav block would not. Deactivating Gutenberg resolved the issue.

@ckmccoy2
Copy link

ckmccoy2 commented Jan 6, 2023

Similar issue here 5843627-zd / 39379470-hc

I tried creating a new menu for the header/footer (since the user only wanted to update just one going forward), but it doesn't seem to have worked

@ckmccoy2
Copy link

ckmccoy2 commented Jan 6, 2023

Not sure if this issue is related or not, but in 39360798-hc, user was trying to add menu items to their existing header menu, but they were not showing up on live site.

Worked around it by creating a new menu in header

@upwardmomentum84
Copy link

Another case here: 5842695-zd-woothemes

Menu in footer would not show. The Site Editor was freezing up as well. Manually adding the Nav block did not work. Deactivated Gutenberg allowed the menu to show and the freezing up issue stopped.

@daria2303
Copy link

5844250-zd-woothemes

Workaround: Added another menu in the Footer.

@nerdysandy
Copy link
Contributor

Reported on 5838664-zd-woothemes

@wiesenhauss
Copy link

wiesenhauss commented Jan 10, 2023

Another case here: 5854450-zd-woothemes

Created a new menu in the site footer as workaround.

@chad1008
Copy link
Contributor

This looks like it's been fixed with the release of 14.9.1 on prod sites, based on my own testing. Can anyone confirm with additional testing on another affected site?

@wiesenhauss
Copy link

This looks like it's been fixed with the release of 14.9.1 on prod sites, based on my own testing. Can anyone confirm with additional testing on another affected site?

I tested on a Business site using the Tsubaki theme (to replicate the issue on a user site). Still not fixed (it seems 14.9.1 was not deployed on Atomic yet)

@chad1008
Copy link
Contributor

Ah yes, good point - thanks for that. It won't be out yet on Atomic, but that should come later today barring anything out of the ordinary.

@darnelldibbles
Copy link

@chad1008
Copy link
Contributor

Looking at @darnelldibbles newest report, it looks like the newest version only partially fixes the issue. There were two symptoms originally:

  1. Setting a footer navigation block to display the header navigation would break the editor
  2. Header navigation menus in the footer weren't displayed on the live site

Testing further, it looks like the current release addresses the first symptom, but not the second. So users can set the menu, but it isn't displayed.

Future reports: Now that we've confirmed the symptoms are more separated than it originally appeared, please include whether your report is for trouble setting a header navigation menu in the footer, or if it's specifically related to the navigation block not being visible on the front end. We should hopefully only see the latter, but it'll be good to have a clear indicator of what each reporter specifically experienced!

@chad1008
Copy link
Contributor

After additional testing, the Header Navigation menus not displaying in the footer don't appear to be WPCOM specific, so I've created an upstream ticket here:
WordPress/gutenberg#47085

@ckmccoy2
Copy link

One more here 38700538-hc

@WunderBart
Copy link
Member

Header navigation menus in the footer weren't displayed on the live site

Reported happening here as well 5862586-zd-woothemes

@getdave
Copy link
Contributor

getdave commented Jan 14, 2023

Thanks for all the reports. The bug has been identified and no further reports are required.

Please see the canonical upstream bug for details and resolution status.

@liviopv
Copy link

liviopv commented Jan 17, 2023

Adding in case we want to send a mass reply:

  • 5865401-zd-woothemes

@getdave
Copy link
Contributor

getdave commented Feb 21, 2023

Ok folks I retested this on Dotcom and I cannot replicate it. Nonetheless I see we are still getting reports.

@jartes @happychait @ccwalburn As this is potentially a relatively major bug, please could you:

  • try to narrow down the conditions under which is bug occurs. Ideally screen recordings and steps.
  • (if necessary) escalate the issue so that others can assist you.
  • consider flagging to development teams to check that the sites in question are using the latest version of Gutenberg Plugin.

I work on Gutenberg Core and it would be really good to know that this issue has been fixed and does not still manifest itself.

Very much appreciated 🙇‍♂️

cc @WunderBart

@jartes
Copy link
Contributor

jartes commented Feb 25, 2023

Hey @getdave! I tried to reproduce this on an Atomic site with the Tsubaki theme and also with a Simple Site with Zoologist theme, and I was not able to reproduce it too.

Just noting that GB 15.1.0 was deployed on Feb 15th but reverted back to 15.0.1 due to an issue. It was finally released on Feb 16th (context p1676483487984929-slack-CB0B2G43X).

@zdenys
Copy link
Contributor

zdenys commented Feb 25, 2023

I can confirm that in 5899100-zd-woothemes the AT site was using Gutenberg 15.0.1 and the Navigation block added in the footer that was using the same menu as the header was not displaying on the frontend. When I turned off Gutenberg plugin, it started showing up.

@getdave
Copy link
Contributor

getdave commented Feb 27, 2023

Thanks @jartes and @zdenys. So to confirm:

  • the fix was included in Gutenberg 15.1.0.
  • this was released to Dotcom but then reverted to 15.0.1 "due to an issue".
  • the bug in question is happening on sites for 15.0.1 - that's expected as the fix is 15.1.0.

I think all we need to confirm this Issue is fixed is for someone to test a fresh AT site and confirm Gutenberg 15.1 (or greater than) is running.

Further bug reports 🙏

For any future bug reports please provide the exact Gutenberg Plugin version the site in question was running.

  • less than 15.1.0 - the bug will be in evidence. Upgrading to > 15.1.0 will fix it.
  • great than > 15.1.0 - the bug should not be in evidence and this is a legit bug.

@liviopv
Copy link

liviopv commented Mar 10, 2023

@getdave I just ran into a case of an Atomic Site using the Munchies theme where this issue still seems to be present, but in a different way. Gutenberg version is 15.3.1.

  • 41326010-hc

The site has the same menu assigned to the Navigation Blocks in the Header and Footer, but in the front end, the Footer shows a different menu:

Header Menu in the Editor

CleanShot 2023-03-10 at 14 49 59@2x

Footer Menu in the Editor

CleanShot 2023-03-10 at 14 50 55@2x

Footer on the front end

CleanShot 2023-03-10 at 14 52 57@2x

@liviopv
Copy link

liviopv commented Mar 10, 2023

@getdave I could reproduce the issue on my test site https://atlivio.wpcomstaging.com/ (Gutenberg 15.3.1) as well, both on Munchies and Twenty Twenty-Three. The results were different, though, but still broken.

Using the Munchies theme, the Footer didn't show anything in the Navigation Block, just like the original bug.

Using Twenty Twenty-Three, the Footer weirdly duplicates the footer credits:

CleanShot 2023-03-10 at 15 06 30@2x

@liviopv
Copy link

liviopv commented Mar 10, 2023

I couldn't reproduce it on a local site, so it doesn't seem to be a core issue.

@hacchism
Copy link

  • Another report in 6056865-zd-woothemes
  • AT site using Tsubaki and Gutenberg version 15.3.1

@msilbers
Copy link

reported in 41988091-hc
AT site using Gutenberg version 15.3.1
theme is Varese

they will try to create the menu manually rather than saving an existing one

@getdave
Copy link
Contributor

getdave commented Mar 27, 2023

Ok I will take another look at this in Gutenberg Core and see if I can replicate it.

@scruffian
Copy link
Member

I think this is still a bug with the way that footer credits are inserted into the menu on WordPress.com. @fullofcaffeine, did you get any further with your investigations?

@Automattic Automattic deleted a comment from scruffian Mar 27, 2023
@karenroldan karenroldan added [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. labels Oct 6, 2023
@karenroldan karenroldan moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Oct 6, 2023
@karenroldan karenroldan added the Triaged To be used when issues have been triaged. label Oct 6, 2023
@github-actions github-actions bot added the [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts label Oct 6, 2023
@cuemarie cuemarie added the Needs retest Flagged for retesting by Quality Engineering label Oct 31, 2023
@mpkelly
Copy link
Contributor

mpkelly commented Apr 19, 2024

Hi @cuemarie, it's not possible from what I can see to follow the steps to reproduce this issue. The footer block will not accept a Navigation block when I tested it. It can only accept a Page List. Therefore, I think that might have "fixed" this issue. The last support ticket was in a year ago too.

Maybe you can retest with the Page List and then consider closing this down if it is not an issue anymore?

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Apr 19, 2024
@cuemarie
Copy link
Author

cuemarie commented Apr 22, 2024

@mpkelly I also see that it's not possible to add a Navigation Block in the header/footer on a free test site, though I see that option on the Explorer plan of another site, which is confusing:

free site explorer plan
CleanShot 2024-04-22 at 10 30 06@2x CleanShot 2024-04-22 at 10 30 18@2x
Theme: TT4 Theme: Muscat

In any case, when I can add the Nav block, it doesn't look like we're defaulting to a specific "Header" or "Footer" specific navigation, so this issue does appear to be resolved through the evolution of the blocks and templates.

CleanShot 2024-04-22 at 10 31 13@2x
same as the nav block in the header

I'll go ahead and close.

@cuemarie cuemarie added the [Closed] Not Reproducible Issue cannot be reproduced. label Apr 22, 2024
@cuemarie
Copy link
Author

Ah, looks like this was resolved upstream and the issue here just wasn't closed: WordPress/gutenberg#47085

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Closed] Not Reproducible Issue cannot be reproduced. Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Full Site Editor The site editor. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Interaction #] > 10 (Automated) interaction count label for better visibility. Please don't add these manualliy. Navigation Needs retest Flagged for retesting by Quality Engineering [Platform] Simple [Pri] High Address as soon as possible after BLOCKER issues [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Status] Fix Inbound Use when a fix is in unreleased component [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended
Development

No branches or pull requests