-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FSE: Navigation Block inside footer breaks when set to display Header Navigation #71681
Comments
|
I've done some testing on this, and while I haven't yet identified exactly when it was introduced, it does look like the changes in the upcoming 14.9.x versions will address the issue. If it hasn't already released on WPCOM before then, and/or if it's still an issue, I can work tomorrow on hunting down the preexisting introduction and fix for the bug - hopefully it's smooth sailing for affected users before then though! 😄 |
Another report here: 39338549-hc / 5841065-zd-woothemes (same user, just noting both for tracking |
Support References This comment is automatically generated. Please do not edit it.
|
For Future HE's encountering this, you can check out some internal discussion here p1672858930739649-slack-C02FMH4G to get a sense of some troubleshooting and timing on 14.9.x , which is expected to resolve this issue! |
|
Another report here: 39368564-hc
The workaround of creating a new menu did not work. |
Similar issue here: 39357260-hc The user had a second Nav block in their header. The first Nav block would show on the live version but the second Nav block would not. Deactivating Gutenberg resolved the issue. |
Similar issue here 5843627-zd / 39379470-hc I tried creating a new menu for the header/footer (since the user only wanted to update just one going forward), but it doesn't seem to have worked |
Not sure if this issue is related or not, but in 39360798-hc, user was trying to add menu items to their existing header menu, but they were not showing up on live site. Worked around it by creating a new menu in header |
Another case here: 5842695-zd-woothemes Menu in footer would not show. The Site Editor was freezing up as well. Manually adding the Nav block did not work. Deactivated Gutenberg allowed the menu to show and the freezing up issue stopped. |
5844250-zd-woothemes Workaround: Added another menu in the Footer. |
Reported on 5838664-zd-woothemes |
Another case here: 5854450-zd-woothemes Created a new menu in the site footer as workaround. |
This looks like it's been fixed with the release of 14.9.1 on prod sites, based on my own testing. Can anyone confirm with additional testing on another affected site? |
I tested on a Business site using the Tsubaki theme (to replicate the issue on a user site). Still not fixed (it seems 14.9.1 was not deployed on Atomic yet) |
Ah yes, good point - thanks for that. It won't be out yet on Atomic, but that should come later today barring anything out of the ordinary. |
Looking at @darnelldibbles newest report, it looks like the newest version only partially fixes the issue. There were two symptoms originally:
Testing further, it looks like the current release addresses the first symptom, but not the second. So users can set the menu, but it isn't displayed. Future reports: Now that we've confirmed the symptoms are more separated than it originally appeared, please include whether your report is for trouble setting a header navigation menu in the footer, or if it's specifically related to the navigation block not being visible on the front end. We should hopefully only see the latter, but it'll be good to have a clear indicator of what each reporter specifically experienced! |
After additional testing, the |
One more here 38700538-hc |
Reported happening here as well 5862586-zd-woothemes |
Thanks for all the reports. The bug has been identified and no further reports are required. Please see the canonical upstream bug for details and resolution status. |
Adding in case we want to send a mass reply:
|
Ok folks I retested this on Dotcom and I cannot replicate it. Nonetheless I see we are still getting reports. @jartes @happychait @ccwalburn As this is potentially a relatively major bug, please could you:
I work on Gutenberg Core and it would be really good to know that this issue has been fixed and does not still manifest itself. Very much appreciated 🙇♂️ cc @WunderBart |
Hey @getdave! I tried to reproduce this on an Atomic site with the Tsubaki theme and also with a Simple Site with Zoologist theme, and I was not able to reproduce it too. Just noting that GB 15.1.0 was deployed on Feb 15th but reverted back to 15.0.1 due to an issue. It was finally released on Feb 16th (context p1676483487984929-slack-CB0B2G43X). |
I can confirm that in 5899100-zd-woothemes the AT site was using Gutenberg 15.0.1 and the Navigation block added in the footer that was using the same menu as the header was not displaying on the frontend. When I turned off Gutenberg plugin, it started showing up. |
Thanks @jartes and @zdenys. So to confirm:
I think all we need to confirm this Issue is fixed is for someone to test a fresh AT site and confirm Gutenberg 15.1 (or greater than) is running. Further bug reports 🙏For any future bug reports please provide the exact Gutenberg Plugin version the site in question was running.
|
@getdave I just ran into a case of an Atomic Site using the Munchies theme where this issue still seems to be present, but in a different way. Gutenberg version is 15.3.1.
The site has the same menu assigned to the Navigation Blocks in the Header and Footer, but in the front end, the Footer shows a different menu: Header Menu in the Editor Footer Menu in the Editor Footer on the front end |
@getdave I could reproduce the issue on my test site https://atlivio.wpcomstaging.com/ (Gutenberg 15.3.1) as well, both on Munchies and Twenty Twenty-Three. The results were different, though, but still broken. Using the Munchies theme, the Footer didn't show anything in the Navigation Block, just like the original bug. Using Twenty Twenty-Three, the Footer weirdly duplicates the footer credits: |
I couldn't reproduce it on a local site, so it doesn't seem to be a core issue. |
|
reported in 41988091-hc they will try to create the menu manually rather than saving an existing one |
Ok I will take another look at this in Gutenberg Core and see if I can replicate it. |
I think this is still a bug with the way that footer credits are inserted into the menu on WordPress.com. @fullofcaffeine, did you get any further with your investigations? |
Hi @cuemarie, it's not possible from what I can see to follow the steps to reproduce this issue. The footer block will not accept a Navigation block when I tested it. It can only accept a Page List. Therefore, I think that might have "fixed" this issue. The last support ticket was in a year ago too. Maybe you can retest with the Page List and then consider closing this down if it is not an issue anymore? |
@mpkelly I also see that it's not possible to add a Navigation Block in the header/footer on a free test site, though I see that option on the Explorer plan of another site, which is confusing:
In any case, when I can add the Nav block, it doesn't look like we're defaulting to a specific "Header" or "Footer" specific navigation, so this issue does appear to be resolved through the evolution of the blocks and templates.
I'll go ahead and close. |
Ah, looks like this was resolved upstream and the issue here just wasn't closed: WordPress/gutenberg#47085 |
Quick summary
Brand new simple site: Trying to set a navigation block inside the footer to display the "Header navigation" breaks the editor altogether.
Existing Sites: This is also impacting users with existing menus. We've had several users come to support today reporting that their footer menus are missing on the live site. We've found in all cases that the nav block in the Footer template part is not set to display the "Footer Navigation", but instead either the "header navigation", or a pre-existing menu.
Steps to reproduce
This issue is a little tough to replicate - I had best luck in a Free empty site, to avoid pre-existing menus.
What you expected to happen
I expected the navigation block in the footer to display the menu I'd built in the header.
What actually happened
The editor breaks, and returning to the editor I can't open the footer template part.
compressed.Screen.Capture.on.2023-01-04.at.11-38-09.mp4
From here, if I edit the Template Part itself, I can select the Header Navigation menu as my footer's nav block. When I return to the original template, though, it freezes again:
Screen.Capture.on.2023-01-04.at.11-56-05.mov
And on the live site, the footer's menu is now missing:
Context
User reported here: 39301919-hc
They noted this issue was not happening yesterday. Discussion with other HEs encountering reports of the same issue here: p1672856428879729-slack-C03TY6J1A
Platform (Simple, Atomic, or both?)
Simple
Theme-specific issue?
FSE themes - replicated with Archeo and Zoologist, and user has reported with Tsubaki as well.
Browser, operating system and other notes
No response
Reproducibility
Consistent
Severity
Some (< 50%)
Available workarounds?
Yes, easy to implement
Workaround details
Creating a new menu in the site footer can work around the issue.
The text was updated successfully, but these errors were encountered: