Signup: Change signup flow for domain only sites #10936

gziolo · 2017-01-25T14:24:41Z

That change allows to create a site only on checkout.
Requires backend patch to make it work: D4196.

Testing

Apply D4196 patch.
Open http://calypso.localhost:3000/start/domain-first.
Pick domain name.
Select domain only flow.
Create your account.
You should see checkout page with the following url: http://calypso.localhost:3000/checkout/no-site.
After checkout you should be redirected to the domain management of the the purchased domain: http://calypso.localhost:3000/domains/manage/domain.live

Testing cart is empty after checkout:

Complete checkout according the steps above
Restart the domain only flow with the same user, you should be able to complete it with a new domain.
-or-
GET the no-site (the "copy as cURL") shopping cart from the API and see it has no products.
You can do so on chrome by copying the request from the network tab and executing on a shell:

curl 'https://public-api.wordpress.com/rest/v1.1/me/shopping-cart/no-site?http_envelope=1&locale=en' -H ....

matticbot · 2017-01-25T14:24:42Z

Test live: https://calypso.live/?branch=update/create-cart-without-site

gziolo · 2017-01-25T14:27:22Z

client/lib/signup/step-actions.js

+	if ( designType === 'domain' ) {
+		// TODO: Find a way to create cart without a site
+		// SignupCart.addToCart depends on the site's slug
+		callback( undefined, [ null, null, domainItem, themeItem ] );


@Tug @drewblaisdell I guess you know better what should be done here. I assume we need to build custom /me/transactions call which creates a site behind the scenes and adds domainItem to the cart.

It's tricky because we now take advantage of site slug and redirect users to /checkout/:siteSlug url when an item is added to the cart. It looks like we need to build new page from scratch. It would work only with a single domain and wouldn't need to have connected site.

drewblaisdell · 2017-02-01T00:30:57Z

client/lib/cart/store/index.js


-	_synchronizer = cartSynchronizer( selectedSite.ID, wpcom );
+	_synchronizer = cartSynchronizer( _cartItem, wpcom );


@gziolo I think _cartItem should be _cartKey.

drewblaisdell · 2017-02-01T02:06:41Z

Thanks for working on this. It is possible to purchase a domain without a site in this PR now. :) The redirect post-checkout-success needs to be updated to point to the domain the user just purchased, and the sites-list needs to be refetched at this point, but otherwise, I think this is close!

yurynix · 2017-02-01T17:14:33Z

I've updated it to cause user re-fetch after checkout of domain only site, also change siteSelection controller to wait for user fetching.

drewblaisdell · 2017-02-01T18:32:14Z

client/my-sites/controller.js

 		const allSitesPath = route.sectionify( context.path );

-		const redirectToPrimary = () => {
-			let redirectPath = `${ context.pathname }/${ sites.getPrimary().slug }`;
+		const onUserReady = () => {


@yurynix Sorry for the previous comment here, I missed your first commit.

a8ci18n · 2017-02-02T00:23:28Z

client/my-sites/upgrades/checkout/checkout.jsx

-			return domainManagementList( selectedSite.slug );
+		if ( cart.create_new_blog ) {
+			notices.info(
+				this.translate( 'Almost done…' )


Hi! I've found a possible matching string that has already been translated 21 times:
translate( 'Almost done' ) ES Score: 10.40
See 2 additional suggestions in the PR translation status page

Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).

drewblaisdell · 2017-02-02T02:06:56Z

I made some changes. They will probably be easier to understand if you read them commit-by-commit.

I changed the method of fetching the updated site list to match the one we use in signup. The method that involved updating the my-sites controller was sending me to a sitepicker instead of the site (perhaps because the site isn't necessarily present in the next response from the sites endpoint). I included revert commits so that we can switch back to @yurynix's method easily if we want, but we'll want to remove them before merging.
Part of this change required addressing an issue that Checkout has had for some time now: getCheckoutCompleteRedirectPath does a lot more that simply return the post-checkout path. I added a commit to move the side effects to handleCheckoutCompleteRedirect. This way, we send PayPal the redirectTo value from getCheckoutCompleteRedirect without triggering any side effects, and can refetch the user/sites in handleCheckoutCompleteRedirect in the case that the user is not checking out through PayPal.

We still need to address the fact that the cart is not cleared during checkout with this PR/patch, so I'm going to label this as Needs Author Reply for now.

yurynix · 2017-02-02T08:48:36Z

Thank you @drewblaisdell , this is awesome.

One concern I had before ( and why I choose to implement user fetch complete validation in the controller ) is:

the part here that from my understanding ( and maybe I'm totally mistaken ) we redirect to paypal, it does it thing and then we go to the success URL from "paypal express" code and therefor don't have a chance to fetch user & sites.

Tug · 2017-02-02T12:15:32Z

Indeed Paypal payment is broken and an error is thrown in redirectToPayPal:

Uncaught TypeError: Cannot read property 'slug' of null
    at Object.redirectToPayPal (app:///./client/my-sites/upgrades/checkout/paypal-payment-box.jsx:105:62)

Other than that it works well!

Tug · 2017-02-02T12:27:42Z

client/my-sites/upgrades/checkout/checkout.jsx

 		}

 		if ( receipt && receipt.receipt_id ) {
-			receiptId = receipt.receipt_id;
-
 			this.props.fetchReceiptCompleted( receiptId, {


Maybe we should simply use the constant value ':receiptId' here, it's a bit confusing otherwise

Tug · 2017-02-02T12:30:53Z

client/my-sites/upgrades/index.js

@@ -252,6 +252,11 @@ module.exports = function() {
 		);

 		page(
+			'/checkout/no-site',


We could generalize to /checkout/:cart-key. Maybe in another PR.

I'm afraid we can't, because of the next route:

/checkout/:domain/:product?

It'll be the same is the route:

/checkout/:cart_key

Given /checkout/tug.blog we can't determine if that's a cart key or a domain

Also maybe we should come up with a better path fragment? https://wordpress.com/checkout/no-site doesn't look really nice for users.

Any ideas? I'm happy to update it :D

I'm out of ideas, but I asked some feedback on Slack.

The domain-first flow isn't public yet, so we can update this in the future if we decide on a different path.

yurynix · 2017-02-02T15:46:09Z

I think the error @Tug mentioned is due of us not having selectedSite in that flow, that's a different issue IMO then what I've mentioned.

stephanethomas

The code looks good so far, great job!

stephanethomas · 2017-02-02T15:18:57Z

client/lib/signup/step-actions.js

-	createSiteWithCart: createSiteWithCart,
+	createCart,
+
+	createSiteWithCart,


If we use the shorthand syntax here then we should probably update the rest of exports as well.

good idea :)

stephanethomas · 2017-02-02T15:21:07Z

client/my-sites/upgrades/cart/secondary-cart.jsx

+			PropTypes.object
+		] )
+	},
+


Thanks for adding those prop types!

stephanethomas · 2017-02-02T15:43:51Z

client/my-sites/upgrades/index.js

@@ -252,6 +252,11 @@ module.exports = function() {
 		);

 		page(
+			'/checkout/no-site',


Also maybe we should come up with a better path fragment? https://wordpress.com/checkout/no-site doesn't look really nice for users.

aidvu

Product LGTM.

Code is 👍, but I'd love if someone else would check it.

aidvu · 2017-02-02T16:15:11Z

client/my-sites/upgrades/checkout/secure-payment-form.jsx

 		products: React.PropTypes.object.isRequired,
-		redirectTo: React.PropTypes.func.isRequired
+		redirectTo: React.PropTypes.func.isRequired,


Babel removes this comma, and it's valid syntax as of ES6+ :)

Tbh, I like the comma, but it wasn't by the docs. Good to know. 😆

…elected site

…and add `handleCheckoutCompleteRedirect`

…checkout We do the same during signup.

The user will be redirected away from `PayButton` when the payment is complete. For some payments, we refetch the sites/user before redirecting, so the transaction will complete before we want the loading state to change.

drewblaisdell · 2017-02-02T19:56:41Z

Looks good to me! I tested:

Purchasing a plan.
Purchasing a plan with a domain.
Purchasing a domain.
Purchasing via PayPal.

The patch has been deployed, so I'm going to merge this.

gziolo added [Feature Group] Emails & Domains Features related to email integrations and domain management. [Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. [Status] In Progress labels Jan 25, 2017

gziolo added this to the Tortuga MVP milestone Jan 25, 2017

gziolo self-assigned this Jan 25, 2017

gziolo commented Jan 25, 2017

View reviewed changes

gziolo force-pushed the update/create-cart-without-site branch 2 times, most recently from 85bc00e to eedd4d2 Compare January 31, 2017 18:08

drewblaisdell reviewed Feb 1, 2017

View reviewed changes

yurynix added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Feb 1, 2017

drewblaisdell reviewed Feb 1, 2017

View reviewed changes

a8ci18n reviewed Feb 2, 2017

View reviewed changes

drewblaisdell added [Status] Needs Author Reply and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 2, 2017

Tug reviewed Feb 2, 2017

View reviewed changes

stephanethomas reviewed Feb 2, 2017

View reviewed changes

aidvu approved these changes Feb 2, 2017

View reviewed changes

gziolo and others added 4 commits February 2, 2017 10:56

Signup: Change signup flow for domain only sites

0b6f8d5

Checkout: Refactor shopping cart to use new API endpoint

9e1a1b2

Checkout: Initialize cartSynchronizer with cartKey derived from s…

bcbadd9

…elected site

Checkout: Add propTypes to SecondaryCart

8ec6690

drewblaisdell added 6 commits February 2, 2017 10:56

Checkout: Add propTypes to CartPlanAd

ce1f617

Checkout: Don't display CartPlanAd when checking out without a site

0e950e8

Checkout: Remove side effects from getCheckoutCompleteRedirectPath …

99d2d36

…and add `handleCheckoutCompleteRedirect`

Checkout: Refetch the sites/user when a site has been created during …

6eb787e

…checkout We do the same during signup.

Checkout: Remove completed state in PayButton

3e8df06

The user will be redirected away from `PayButton` when the payment is complete. For some payments, we refetch the sites/user before redirecting, so the transaction will complete before we want the loading state to change.

Checkout: Add notice to give user feedback while sites/user refetch

dd9d46b

drewblaisdell force-pushed the update/create-cart-without-site branch from 1d6543d to dd9d46b Compare February 2, 2017 19:18

drewblaisdell added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Author Reply labels Feb 2, 2017

drewblaisdell added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 2, 2017

drewblaisdell merged commit 87b7652 into master Feb 2, 2017

matticbot removed the [Status] Ready to Merge label Feb 2, 2017

Tug deleted the update/create-cart-without-site branch February 2, 2017 21:01

drewblaisdell restored the update/create-cart-without-site branch February 2, 2017 22:08

drewblaisdell deleted the update/create-cart-without-site branch February 2, 2017 22:08

drewblaisdell mentioned this pull request Feb 2, 2017

Revert "Signup: Change signup flow for domain only sites" #11140

Closed

drewblaisdell mentioned this pull request Feb 25, 2017

Signup: Fix site path through domain-first flow #11601

Merged

2 tasks

sirbrillig mentioned this pull request Nov 8, 2022

Checkout: remove post-checkout polling for site for create_new_blog #69837

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Signup: Change signup flow for domain only sites #10936

Signup: Change signup flow for domain only sites #10936

gziolo commented Jan 25, 2017 •

edited by yurynix

Loading

matticbot commented Jan 25, 2017

gziolo Jan 25, 2017 •

edited

Loading

gziolo Jan 25, 2017

drewblaisdell Feb 1, 2017

drewblaisdell commented Feb 1, 2017 •

edited

Loading

yurynix commented Feb 1, 2017

drewblaisdell Feb 1, 2017 •

edited

Loading

a8ci18n Feb 2, 2017 •

edited

Loading

drewblaisdell commented Feb 2, 2017

yurynix commented Feb 2, 2017 •

edited

Loading

Tug commented Feb 2, 2017

Tug Feb 2, 2017 •

edited

Loading

Tug Feb 2, 2017

yurynix Feb 2, 2017

stephanethomas Feb 2, 2017

gziolo Feb 2, 2017

stephanethomas Feb 2, 2017

drewblaisdell Feb 2, 2017

yurynix commented Feb 2, 2017

stephanethomas left a comment

stephanethomas Feb 2, 2017

gziolo Feb 2, 2017

stephanethomas Feb 2, 2017

stephanethomas Feb 2, 2017

aidvu left a comment

aidvu Feb 2, 2017

gziolo Feb 2, 2017

aidvu Feb 2, 2017

drewblaisdell commented Feb 2, 2017


		_synchronizer = cartSynchronizer( selectedSite.ID, wpcom );
		_synchronizer = cartSynchronizer( _cartItem, wpcom );

Signup: Change signup flow for domain only sites #10936

Signup: Change signup flow for domain only sites #10936

Conversation

gziolo commented Jan 25, 2017 • edited by yurynix Loading

Testing

Testing cart is empty after checkout:

matticbot commented Jan 25, 2017

gziolo Jan 25, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

drewblaisdell commented Feb 1, 2017 • edited Loading

yurynix commented Feb 1, 2017

drewblaisdell Feb 1, 2017 • edited Loading

Choose a reason for hiding this comment

a8ci18n Feb 2, 2017 • edited Loading

Choose a reason for hiding this comment

drewblaisdell commented Feb 2, 2017

yurynix commented Feb 2, 2017 • edited Loading

Tug commented Feb 2, 2017

Tug Feb 2, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yurynix commented Feb 2, 2017

stephanethomas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aidvu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

drewblaisdell commented Feb 2, 2017

gziolo commented Jan 25, 2017 •

edited by yurynix

Loading

gziolo Jan 25, 2017 •

edited

Loading

drewblaisdell commented Feb 1, 2017 •

edited

Loading

drewblaisdell Feb 1, 2017 •

edited

Loading

a8ci18n Feb 2, 2017 •

edited

Loading

yurynix commented Feb 2, 2017 •

edited

Loading

Tug Feb 2, 2017 •

edited

Loading