Purchases: Rename constants for upgrade actions to be more consistent #1253
Conversation
…o be more consistent
…n to be more consistent
This doesn't respect exactly the naming convention because unfortunately we use the same action in case of failure. However it at least reflects the fact that this is a server action (as opposed to a view action).
…e more consistent
…n to be more consistent
…ion action to be more consistent
stephanethomas
added
[Status] Needs Review
| PRIVACY_PROTECTION_CANCEL: null, | ||
| PRIVACY_PROTECTION_CANCEL_COMPLETED: null, | ||
| PRIVACY_PROTECTION_CANCEL_FAILED: null, | ||
| PRIVACY_PROTECTION_ENABLE_COMPLETED: null, |
There was a problem hiding this comment.
This is one looks like a lonely one ;) Of course not related to this PR, but we should double check that part of Domain Management.
DOMAIN_LOCKING_ENABLE_COMPLETED & ICANN_VERIFICATION_RESEND_COMPLETED are another constants to check.
There was a problem hiding this comment.
There are in fact other inconsistencies. For example the delete DNS action is plain wrong: we're currently missing a DNS_DELETE_COMPLETED event and we're expecting an error object in the payload of the DELETING_DNS event that we never pass. And I'm not talking of how we handle errors :).
@fabianapsimoes, we should probably take care of that at some point.
There was a problem hiding this comment.
@stephanethomas can you open a new issue for that? I'm guessing this falls under Cobalt's realm, so pinging @aidvu.
There was a problem hiding this comment.
Thanks @fabianapsimoes. @klimeryk will pick it probably.
|
Code changes look awesome. Great job on this one 👍 |
|
I tested domain management, domain search, plans, purchases, checkout. If there's nothing else to test this LGTM 👍 |
scruffian
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Purchases: Rename constants for upgrade actions to be more consistent
This pull request makes sure that constants for store events all follow the same naming convention. This naming convention - which is heavily inspired from Ian Obermiller's post - was discussed some times ago internally but we never found the time to actually update our code. Well, I had some free time during my flight from London to Philadelphia so here it goes :).
The logic didn't change and everything should work as before.
Review