Adding support for Discover's fullbleed class. #2942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lets big images break out of the frame if the editors choose for them to.
kjellr
added
[Feature] Reader
|
@bluefuton It looks like we cap the size of images at 1440px wide ( |
|
@kjellr we can probably do that. nice work! |
Also fix the resize-image-url function to understand high DPI screens.
|
There we go, that should do it. 37052c3 |
|
Awesome, thanks @blowery! Tested it out on a couple additional posts and it looks great! |
blowery
added a commit
that referenced
this pull request
Feb 2, 2016
Adding support for Discover's fullbleed class.
jancavan
removed
the
[Status] Needs Review
This was referenced Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Discover editors apply a
fullbleedclass to images on discover.wordpress.com, we extend the images outside the boundaries of the text column. We’d like to bring this behavior to the Reader as well.Extends the width by 175px in each direction, aligning with the Discover sidenotes from PR #2729. Larger viewports only: no change to screens under 1132px.
Examples:
Article: https://discover.wordpress.com/2015/12/28/rob-turpin-interview/
Reader: http://calypso.localhost:3000/read/post/id/53424024/1661
Article: https://discover.wordpress.com/2016/01/21/fennabee/
Reader: http://calypso.localhost:3000/read/post/id/53424024/9037